Skip to content

Commit 9137123

Browse files
Merge pull request #53 from SimformSolutionsPvtLtd/refactor/UNT-T26896_file_rename_and_warning
refactor(UNT-T26896): file rename and react warning
2 parents 9c3efa7 + 4cbef82 commit 9137123

File tree

5 files changed

+10
-5
lines changed

5 files changed

+10
-5
lines changed

src/components/Waveform/Waveform.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ export const Waveform = forwardRef<IWaveformRef, IWaveform>((props, ref) => {
4141
const {
4242
mode,
4343
path,
44+
volume = 3,
4445
candleSpace = 2,
4546
candleWidth = 5,
4647
containerStyle = {},
@@ -93,7 +94,7 @@ export const Waveform = forwardRef<IWaveformRef, IWaveform>((props, ref) => {
9394
path,
9495
playerKey: `PlayerFor${path}`,
9596
updateFrequency: UpdateFrequency.medium,
96-
volume: 10,
97+
volume: volume,
9798
});
9899
return Promise.resolve(prepare);
99100
} catch (err) {

src/components/Waveform/WaveformTypes.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ interface BaseWaveform {
1616
export interface StaticWaveform extends BaseWaveform {
1717
mode: 'static';
1818
path: string;
19+
volume?: number;
1920
scrubColor?: string;
2021
onPlayerStateChange?: (playerState: PlayerState) => void;
2122
onPanStateChange?: (panMoving: boolean) => void;

src/components/WaveformCandle/WaveformCandle.tsx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { Colors } from '../../theme';
44
import styles from './WaveformCandleStyles';
55
import type { IWaveformCandle } from './WaveformCandleTypes';
66

7-
export const WaveformCandle = ({
7+
export const WaveformCandle: React.FC<IWaveformCandle> = ({
88
index,
99
amplitude,
1010
parentViewLayout,
@@ -15,8 +15,8 @@ export const WaveformCandle = ({
1515
currentProgress = 0,
1616
waveColor,
1717
scrubColor,
18-
candleHeightScale
19-
}: IWaveformCandle) => {
18+
candleHeightScale,
19+
}) => {
2020
const maxHeight = (parentViewLayout?.height ?? 0) - 10;
2121
const completedIndex = (currentProgress / songDuration) * noOfSamples;
2222

@@ -43,7 +43,10 @@ export const WaveformCandle = ({
4343
width: candleWidth,
4444
marginRight: candleSpace,
4545
maxHeight,
46-
height: (isNaN(amplitude) ? 0 : amplitude) * maxHeight * candleHeightScale, // Adjust the height scale as needed
46+
height:
47+
(isNaN(amplitude) ? 0 : amplitude) *
48+
maxHeight *
49+
candleHeightScale, // Adjust the height scale as needed
4750
minHeight: candleWidth,
4851
borderRadius: candleWidth,
4952
},

0 commit comments

Comments
 (0)