Skip to content

Commit 974ea61

Browse files
authored
Merge pull request #2589 from FrankSpringfield/main
[PLM251120-09263][PLM251120-09698] Hide some specific events in history
2 parents 37691d5 + 641a5a7 commit 974ea61

File tree

2 files changed

+28
-28
lines changed

2 files changed

+28
-28
lines changed

drivers/SmartThings/zigbee-bed/src/shus-mattress/init.lua

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ end
3636

3737
local function process_control_attr_factory(cmd)
3838
return function(driver, device, value, zb_rx)
39-
device:emit_event(cmd.idle())
39+
device:emit_event(cmd("idle", { visibility = { displayed = false }}))
4040
end
4141
end
4242

@@ -129,7 +129,7 @@ local function process_capabilities_hardness_factory(cap,attrs,cap_attr)
129129
)
130130
--A button that can be triggered continuously
131131
local evt_ctrl = cap_attr.soft()
132-
local evt_idle = cap_attr.idle()
132+
local evt_idle = cap_attr("idle", { visibility = { displayed = false }})
133133
if cmd.args[cap] == "hard" then
134134
evt_ctrl = cap_attr.hard()
135135
end
@@ -148,7 +148,7 @@ local function device_init(driver, device)
148148
end
149149

150150
local function device_added(driver, device)
151-
device:emit_event(custom_capabilities.yoga.supportedYogaState({"stop", "left", "right"}))
151+
device:emit_event(custom_capabilities.yoga.supportedYogaState({"stop", "left", "right"}, { visibility = { displayed = false }}))
152152
do_refresh(driver, device)
153153
end
154154

drivers/SmartThings/zigbee-bed/src/test/test_shus_mattress.lua

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ test.register_coroutine_test(
5959
function()
6060
test.socket.device_lifecycle:__queue_receive({ mock_device.id, "added" })
6161
test.socket.capability:__expect_send(mock_device:generate_test_message("main",
62-
custom_capabilities.yoga.supportedYogaState({"stop", "left", "right"}) ))
62+
custom_capabilities.yoga.supportedYogaState({"stop", "left", "right"}, { visibility = { displayed = false }}) ))
6363
local read_0x0006_messge = cluster_base.read_manufacturer_specific_attribute(mock_device, PRIVATE_CLUSTER_ID, 0x0006, MFG_CODE)
6464
local read_0x0007_messge = cluster_base.read_manufacturer_specific_attribute(mock_device, PRIVATE_CLUSTER_ID, 0x0007, MFG_CODE)
6565
local read_0x0009_messge = cluster_base.read_manufacturer_specific_attribute(mock_device, PRIVATE_CLUSTER_ID, 0x0009, MFG_CODE)
@@ -140,7 +140,7 @@ test.register_coroutine_test(
140140
)
141141

142142
test.register_coroutine_test(
143-
"Device reported leftback 0 and driver emit custom_capabilities.left_control.leftback.idle()",
143+
"Device reported leftback 0 and driver emit custom_capabilities.left_control.leftback.idle({ visibility = { displayed = false }})",
144144
function()
145145
local attr_report_data = {
146146
{ 0x0000, data_types.Uint8.ID, 0 }
@@ -150,12 +150,12 @@ test.register_coroutine_test(
150150
zigbee_test_utils.build_attribute_report(mock_device, PRIVATE_CLUSTER_ID, attr_report_data, MFG_CODE)
151151
})
152152
test.socket.capability:__expect_send(mock_device:generate_test_message("main",
153-
custom_capabilities.left_control.leftback.idle()))
153+
custom_capabilities.left_control.leftback.idle({ visibility = { displayed = false }})))
154154
end
155155
)
156156

157157
test.register_coroutine_test(
158-
"Device reported leftback 1 and driver emit custom_capabilities.left_control.leftback.idle()",
158+
"Device reported leftback 1 and driver emit custom_capabilities.left_control.leftback.idle({ visibility = { displayed = false }})",
159159
function()
160160
local attr_report_data = {
161161
{ 0x0000, data_types.Uint8.ID, 1 }
@@ -165,12 +165,12 @@ test.register_coroutine_test(
165165
zigbee_test_utils.build_attribute_report(mock_device, PRIVATE_CLUSTER_ID, attr_report_data, MFG_CODE)
166166
})
167167
test.socket.capability:__expect_send(mock_device:generate_test_message("main",
168-
custom_capabilities.left_control.leftback.idle()))
168+
custom_capabilities.left_control.leftback.idle({ visibility = { displayed = false }})))
169169
end
170170
)
171171

172172
test.register_coroutine_test(
173-
"Device reported leftwaist 0 and driver emit custom_capabilities.left_control.leftwaist.idle()",
173+
"Device reported leftwaist 0 and driver emit custom_capabilities.left_control.leftwaist.idle({ visibility = { displayed = false }})",
174174
function()
175175
local attr_report_data = {
176176
{ 0x0001, data_types.Uint8.ID, 0 }
@@ -180,12 +180,12 @@ test.register_coroutine_test(
180180
zigbee_test_utils.build_attribute_report(mock_device, PRIVATE_CLUSTER_ID, attr_report_data, MFG_CODE)
181181
})
182182
test.socket.capability:__expect_send(mock_device:generate_test_message("main",
183-
custom_capabilities.left_control.leftwaist.idle()))
183+
custom_capabilities.left_control.leftwaist.idle({ visibility = { displayed = false }})))
184184
end
185185
)
186186

187187
test.register_coroutine_test(
188-
"Device reported leftwaist 1 and driver emit custom_capabilities.left_control.leftwaist.idle()",
188+
"Device reported leftwaist 1 and driver emit custom_capabilities.left_control.leftwaist.idle({ visibility = { displayed = false }})",
189189
function()
190190
local attr_report_data = {
191191
{ 0x0001, data_types.Uint8.ID, 1 }
@@ -195,12 +195,12 @@ test.register_coroutine_test(
195195
zigbee_test_utils.build_attribute_report(mock_device, PRIVATE_CLUSTER_ID, attr_report_data, MFG_CODE)
196196
})
197197
test.socket.capability:__expect_send(mock_device:generate_test_message("main",
198-
custom_capabilities.left_control.leftwaist.idle()))
198+
custom_capabilities.left_control.leftwaist.idle({ visibility = { displayed = false }})))
199199
end
200200
)
201201

202202
test.register_coroutine_test(
203-
"Device reported lefthip 0 and driver emit custom_capabilities.left_control.lefthip.idle()",
203+
"Device reported lefthip 0 and driver emit custom_capabilities.left_control.lefthip.idle({ visibility = { displayed = false }})",
204204
function()
205205
local attr_report_data = {
206206
{ 0x0002, data_types.Uint8.ID, 0 }
@@ -210,12 +210,12 @@ test.register_coroutine_test(
210210
zigbee_test_utils.build_attribute_report(mock_device, PRIVATE_CLUSTER_ID, attr_report_data, MFG_CODE)
211211
})
212212
test.socket.capability:__expect_send(mock_device:generate_test_message("main",
213-
custom_capabilities.left_control.lefthip.idle()))
213+
custom_capabilities.left_control.lefthip.idle({ visibility = { displayed = false }})))
214214
end
215215
)
216216

217217
test.register_coroutine_test(
218-
"Device reported lefthip 1 and driver emit custom_capabilities.left_control.lefthip.idle()",
218+
"Device reported lefthip 1 and driver emit custom_capabilities.left_control.lefthip.idle({ visibility = { displayed = false }})",
219219
function()
220220
local attr_report_data = {
221221
{ 0x0002, data_types.Uint8.ID, 1 }
@@ -225,12 +225,12 @@ test.register_coroutine_test(
225225
zigbee_test_utils.build_attribute_report(mock_device, PRIVATE_CLUSTER_ID, attr_report_data, MFG_CODE)
226226
})
227227
test.socket.capability:__expect_send(mock_device:generate_test_message("main",
228-
custom_capabilities.left_control.lefthip.idle()))
228+
custom_capabilities.left_control.lefthip.idle({ visibility = { displayed = false }})))
229229
end
230230
)
231231

232232
test.register_coroutine_test(
233-
"Device reported rightback 0 and driver emit custom_capabilities.right_control.rightback.idle()",
233+
"Device reported rightback 0 and driver emit custom_capabilities.right_control.rightback.idle({ visibility = { displayed = false }})",
234234
function()
235235
local attr_report_data = {
236236
{ 0x0003, data_types.Uint8.ID, 0 }
@@ -240,12 +240,12 @@ test.register_coroutine_test(
240240
zigbee_test_utils.build_attribute_report(mock_device, PRIVATE_CLUSTER_ID, attr_report_data, MFG_CODE)
241241
})
242242
test.socket.capability:__expect_send(mock_device:generate_test_message("main",
243-
custom_capabilities.right_control.rightback.idle()))
243+
custom_capabilities.right_control.rightback.idle({ visibility = { displayed = false }})))
244244
end
245245
)
246246

247247
test.register_coroutine_test(
248-
"Device reported rightback 1 and driver emit custom_capabilities.right_control.rightback.idle()",
248+
"Device reported rightback 1 and driver emit custom_capabilities.right_control.rightback.idle({ visibility = { displayed = false }})",
249249
function()
250250
local attr_report_data = {
251251
{ 0x0003, data_types.Uint8.ID, 1 }
@@ -255,12 +255,12 @@ test.register_coroutine_test(
255255
zigbee_test_utils.build_attribute_report(mock_device, PRIVATE_CLUSTER_ID, attr_report_data, MFG_CODE)
256256
})
257257
test.socket.capability:__expect_send(mock_device:generate_test_message("main",
258-
custom_capabilities.right_control.rightback.idle()))
258+
custom_capabilities.right_control.rightback.idle({ visibility = { displayed = false }})))
259259
end
260260
)
261261

262262
test.register_coroutine_test(
263-
"Device reported rightwaist 0 and driver emit custom_capabilities.right_control.rightwaist.idle()",
263+
"Device reported rightwaist 0 and driver emit custom_capabilities.right_control.rightwaist.idle({ visibility = { displayed = false }})",
264264
function()
265265
local attr_report_data = {
266266
{ 0x0004, data_types.Uint8.ID, 0 }
@@ -270,12 +270,12 @@ test.register_coroutine_test(
270270
zigbee_test_utils.build_attribute_report(mock_device, PRIVATE_CLUSTER_ID, attr_report_data, MFG_CODE)
271271
})
272272
test.socket.capability:__expect_send(mock_device:generate_test_message("main",
273-
custom_capabilities.right_control.rightwaist.idle()))
273+
custom_capabilities.right_control.rightwaist.idle({ visibility = { displayed = false }})))
274274
end
275275
)
276276

277277
test.register_coroutine_test(
278-
"Device reported rightwaist 1 and driver emit custom_capabilities.right_control.rightwaist.idle()",
278+
"Device reported rightwaist 1 and driver emit custom_capabilities.right_control.rightwaist.idle({ visibility = { displayed = false }})",
279279
function()
280280
local attr_report_data = {
281281
{ 0x0004, data_types.Uint8.ID, 1 }
@@ -285,12 +285,12 @@ test.register_coroutine_test(
285285
zigbee_test_utils.build_attribute_report(mock_device, PRIVATE_CLUSTER_ID, attr_report_data, MFG_CODE)
286286
})
287287
test.socket.capability:__expect_send(mock_device:generate_test_message("main",
288-
custom_capabilities.right_control.rightwaist.idle()))
288+
custom_capabilities.right_control.rightwaist.idle({ visibility = { displayed = false }})))
289289
end
290290
)
291291

292292
test.register_coroutine_test(
293-
"Device reported righthip 0 and driver emit custom_capabilities.right_control.righthip.idle()",
293+
"Device reported righthip 0 and driver emit custom_capabilities.right_control.righthip.idle({ visibility = { displayed = false }})",
294294
function()
295295
local attr_report_data = {
296296
{ 0x0005, data_types.Uint8.ID, 0 }
@@ -300,12 +300,12 @@ test.register_coroutine_test(
300300
zigbee_test_utils.build_attribute_report(mock_device, PRIVATE_CLUSTER_ID, attr_report_data, MFG_CODE)
301301
})
302302
test.socket.capability:__expect_send(mock_device:generate_test_message("main",
303-
custom_capabilities.right_control.righthip.idle()))
303+
custom_capabilities.right_control.righthip.idle({ visibility = { displayed = false }})))
304304
end
305305
)
306306

307307
test.register_coroutine_test(
308-
"Device reported righthip 1 and driver emit custom_capabilities.right_control.righthip.idle()",
308+
"Device reported righthip 1 and driver emit custom_capabilities.right_control.righthip.idle({ visibility = { displayed = false }})",
309309
function()
310310
local attr_report_data = {
311311
{ 0x0005, data_types.Uint8.ID, 1 }
@@ -315,7 +315,7 @@ test.register_coroutine_test(
315315
zigbee_test_utils.build_attribute_report(mock_device, PRIVATE_CLUSTER_ID, attr_report_data, MFG_CODE)
316316
})
317317
test.socket.capability:__expect_send(mock_device:generate_test_message("main",
318-
custom_capabilities.right_control.righthip.idle()))
318+
custom_capabilities.right_control.righthip.idle({ visibility = { displayed = false }})))
319319
end
320320
)
321321

0 commit comments

Comments
 (0)