fix: StorageInstance.exists returns boolean and LocalStorage handles undefined folder

Signed-off-by: fazeel332@gmail.com <fazeel332@gmail.com>

Author: fazeelzafar

packages/core/src/subsystems/IO/Storage.service/connectors/LocalStorage.class.ts

@@ -49,7 +49,7 @@ export class LocalStorage extends StorageConnector {
     private findStorageFolder(folder) {
         let _storageFolder = folder;
 
-        if (fs.existsSync(_storageFolder)) {
+        if (_storageFolder && fs.existsSync(_storageFolder)) {
             return _storageFolder;
         }
 

packages/core/tests/unit/core/LocalStorage.test.ts

@@ -0,0 +1,36 @@
+import { LocalStorage } from '@sre/IO/Storage.service/connectors/LocalStorage.class';
+import { describe, expect, it } from 'vitest';
+
+describe('LocalStorage Tests', () => {
+    it('should initialize with undefined folder without crashing', () => {
+        // Test with undefined settings
+        expect(() => {
+            new LocalStorage();
+        }).not.toThrow();
+
+        // Test with empty settings object
+        expect(() => {
+            new LocalStorage({});
+        }).not.toThrow();
+
+        // Test with explicitly undefined folder
+        expect(() => {
+            new LocalStorage({ folder: undefined });
+        }).not.toThrow();
+    });
+
+    it('should initialize with valid folder path', () => {
+        const tempDir = require('os').tmpdir();
+        
+        expect(() => {
+            new LocalStorage({ folder: tempDir });
+        }).not.toThrow();
+    });
+
+    it('should handle non-existent folder gracefully', () => {
+        // This should not crash but may log warnings as designed
+        expect(() => {
+            new LocalStorage({ folder: '/non/existent/path/that/should/not/exist' });
+        }).not.toThrow();
+    });
+});

packages/sdk/src/Storage/StorageInstance.class.ts

@@ -119,11 +119,10 @@ export class StorageInstance extends SDKObject {
      * @param resourceName - The name or smythfs:// uri of the resource to check
      * @returns true if the resource exists, false otherwise
      */
-    async exists(resourceName: string) {
+    async exists(resourceName: string): Promise<boolean> {
         const uri = resourceName.startsWith('smythfs://') ? resourceName : await this.getResourceUri(resourceName);
         try {
-            await this.fs.exists(uri, this._candidate);
-            return uri;
+            return await this.fs.exists(uri, this._candidate);
         } catch (error) {
             console.error(error);
             throw error;