I can close the terminal tab even if there is a running command?

[blueberryscone238]

I don't think it should be this way!

It should warn that there is a running command and ask the user for confirmation.

[SpartanJ]

This has been requested before and I rejected it because I don't like it and I don't think a code editor should take care of that. It could be optional though. Let me think about it.

[blueberryscone238]

I'm cloning a very large git repository. I accidentally ctrl+w the terminal tab. What will happen? Is git still running in the background, but I just can't see the output? Or does the process get terminated immediately when the terminal tab is closed?

Both are equally bad in my opinion.

[SpartanJ]

Process is killed immediately. Terminal multiplexers are your friends too.

[blueberryscone238]

I think terminal multiplexers are just a clever workaround for current limitations. We use them primarily for their session management capabilities—not because we need their full range of features. If possible, I’d prefer not to rely on them.

[blueberryscone238]

If checking to see if there is a running command is too complicated, this is a workaround: #648.

[blueberryscone238]

If checking to see if there is a running command is too complicated, this is a workaround: #648.

My research with Copilot tells me that implementing this feature is not that complicated. So we don't need #648.

It can tell me how to check if a process (in this case, the shell) has child processes for all platforms in existence, from Windows, Linux, macOS, to all BSD and HaikuOS.

I think the logic is very simple: If the shell has child processes still running, let's warn the users and ask for confirmation.

Please correct me if I'm wrong.

I don't think pin tab is that interesting as a feature to be honest.

Yes. I think the same.

[GB18030-2000]

Don't tell me that's also the default behavior of eterm! All modern terminal emulators prevent closing a tab if a foreground process is running. This helps avoid accidentally killing important tasks. If it is already implemented in eterm, then copying the code to ecode should be pretty straightforward!

[SpartanJ]

I think the logic is very simple: If the shell has child processes still running, let's warn the users and ask for confirmation.

Yes, you're correct, and as you can see I did not close the issue because I'm going to implement it.

[GB18030-2000]

I think the logic is very simple: If the shell has child processes still running, let's warn the users and ask for confirmation.

Yes, you're correct, and as you can see I did not close the issue because I'm going to implement it.

Please make it available on eterm as well.

[SpartanJ]

Added, feature will be enabled by default. It can be disabled at Settings -> Terminal -> Warn Before Closing Tab.

On a side-note:
It's disabled by default in eterm, but it can be enabled by passing --warn-before-closing.