Skip to content

Commit d340536

Browse files
ygerpre-commit-ci[bot]samuelgarcia
authored
Fix silence period and job_kwargs (#4071)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Garcia Samuel <sam.garcia.die@gmail.com>
1 parent b5bfa54 commit d340536

File tree

1 file changed

+19
-10
lines changed

1 file changed

+19
-10
lines changed

src/spikeinterface/preprocessing/silence_periods.py

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
from spikeinterface.core.core_tools import define_function_handling_dict_from_class
66
from .basepreprocessor import BasePreprocessor, BasePreprocessorSegment
77

8-
from spikeinterface.core import get_random_data_chunks, get_noise_levels
8+
from spikeinterface.core import get_noise_levels
99
from spikeinterface.core.generate import NoiseGeneratorRecording
10+
from spikeinterface.core.job_tools import split_job_kwargs
1011

1112

1213
class SilencedPeriodsRecording(BasePreprocessor):
@@ -36,15 +37,23 @@ class SilencedPeriodsRecording(BasePreprocessor):
3637
- "noise": The periods are filled with a gaussion noise that has the
3738
same variance that the one in the recordings, on a per channel
3839
basis
39-
**random_chunk_kwargs : Keyword arguments for `spikeinterface.core.get_random_data_chunk()` function
40+
**noise_levels_kwargs : Keyword arguments for `spikeinterface.core.get_noise_levels()` function
4041
4142
Returns
4243
-------
4344
silence_recording : SilencedPeriodsRecording
4445
The recording extractor after silencing some periods
4546
"""
4647

47-
def __init__(self, recording, list_periods, mode="zeros", noise_levels=None, seed=None, **random_chunk_kwargs):
48+
def __init__(
49+
self,
50+
recording,
51+
list_periods,
52+
mode="zeros",
53+
noise_levels=None,
54+
seed=None,
55+
**noise_levels_kwargs,
56+
):
4857
available_modes = ("zeros", "noise")
4958
num_seg = recording.get_num_segments()
5059

@@ -71,11 +80,10 @@ def __init__(self, recording, list_periods, mode="zeros", noise_levels=None, see
7180

7281
if mode in ["noise"]:
7382
if noise_levels is None:
74-
random_slices_kwargs = random_chunk_kwargs.copy()
75-
random_slices_kwargs["seed"] = seed
76-
noise_levels = get_noise_levels(
77-
recording, return_in_uV=False, random_slices_kwargs=random_slices_kwargs
78-
)
83+
noise_levels_kwargs = noise_levels_kwargs.copy()
84+
noise_levels_kwargs["return_in_uV"] = False
85+
noise_levels_kwargs["seed"] = seed
86+
noise_levels = get_noise_levels(recording, **noise_levels_kwargs)
7987
noise_generator = NoiseGeneratorRecording(
8088
num_channels=recording.get_num_channels(),
8189
sampling_frequency=recording.sampling_frequency,
@@ -97,8 +105,9 @@ def __init__(self, recording, list_periods, mode="zeros", noise_levels=None, see
97105
rec_segment = SilencedPeriodsRecordingSegment(parent_segment, periods, mode, noise_generator, seg_index)
98106
self.add_recording_segment(rec_segment)
99107

100-
self._kwargs = dict(recording=recording, list_periods=list_periods, mode=mode, seed=seed)
101-
self._kwargs.update(random_chunk_kwargs)
108+
self._kwargs = dict(
109+
recording=recording, list_periods=list_periods, mode=mode, seed=seed, noise_levels=noise_levels
110+
)
102111

103112

104113
class SilencedPeriodsRecordingSegment(BasePreprocessorSegment):

0 commit comments

Comments
 (0)