From 4131eba5da9cd8b83faa1ea117a8c8e21db7160e Mon Sep 17 00:00:00 2001 From: 902seanryan Date: Wed, 12 Mar 2025 15:15:13 -0300 Subject: [PATCH 1/2] check report errors properly --- src/tools/FileLinter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/FileLinter.js b/src/tools/FileLinter.js index 4efbe6d..1b6f8cf 100644 --- a/src/tools/FileLinter.js +++ b/src/tools/FileLinter.js @@ -54,7 +54,7 @@ async function run(path, config, logResults = false) { console.log(results.reports.join('\n')); } - if (report.errorCount === 0) { + if (results.reports.length === 0) { return results; } else { throw results; From ba129bdc75b25bcc869f6570077ed05250d4f637 Mon Sep 17 00:00:00 2001 From: 902seanryan Date: Wed, 12 Mar 2025 15:16:46 -0300 Subject: [PATCH 2/2] versions and changelog --- CHANGELOG.md | 4 ++++ package-lock.json | 5 +++-- package.json | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 384a00c..32efb8d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [2.2.1] - unreleased + +- Switch error count check in FileLinter.js to properly check for any error reports + ## [2.2.0] - 2024-10-16 - Linter now errors on loose equalities, var for variable definition, and for...of loops [ticket](https://www.pivotaltracker.com/story/show/188211631) diff --git a/package-lock.json b/package-lock.json index ecd1fa0..5c4543e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "springroll-automated-qa", - "version": "2.2.0", + "version": "2.2.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "springroll-automated-qa", - "version": "2.2.0", + "version": "2.2.1", "license": "ISC", "dependencies": { "@typescript-eslint/eslint-plugin": "^5.47.0", @@ -247,6 +247,7 @@ } }, "node_modules/@pbs/eslint-config-pbs-kids/eslint-plugin-pbs-kids": { + "version": "1.0.0", "dev": true }, "node_modules/@socket.io/component-emitter": { diff --git a/package.json b/package.json index 332fd01..92b4157 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "springroll-automated-qa", - "version": "2.2.0", + "version": "2.2.1", "description": "An automated QA tool for SpringRoll games", "main": "src/index.js", "bin": {