Skip to content

Conversation

@immortal-boy
Copy link
Contributor

@immortal-boy immortal-boy commented Dec 5, 2025

Fix RecurrentPPO and MaskablePPO forward and predict do not reshape action before clip it (#317)

Description

Context

closes #317

  • I have raised an issue to propose this change (required)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • The functionality/performance matches that of the source (required for new training algorithms or training-related features).
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have included an example of using the feature (required for new features).
  • I have included baseline results (required for new training algorithms or training-related features).
  • I have updated the documentation accordingly.
  • I have updated the changelog accordingly (required).
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

@araffin araffin changed the title Fix RecurrentPPO and MaskablePPO forward and predict do not reshape action before clip it (#317) Add support for multi-dimensional action spaces to PPO variants Dec 5, 2025
Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks =), please add a quick test to check that this actually fixes the original problem (see PR checklist)

@araffin araffin added the PR template not filled Please fill the pull request template label Dec 5, 2025
@araffin araffin removed the PR template not filled Please fill the pull request template label Dec 7, 2025
@araffin araffin merged commit e03aa1e into Stable-Baselines-Team:master Dec 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RecurrentPPO forward and predict do not reshape action before clip it

2 participants