Fix and simplify FillAllHelper quick panel tab completion

1. fix hitting tab not inserting selected text (due to calling `hide_overlay`)
2. directly call built-in `"select"` instead of custom plugin command.
3. remove obsolete input_quickpanel module and directly track visible
   FillAllHelper quick panels in latex_fill_all module
4. enable `tab` key only if `setting.auto_complete_commit_on_tab` is set.
   Otherwise `tab` and `shift+tab` cycle through items like arrow keys.

Author: deathaxe

Default (Linux).sublime-keymap

@@ -424,10 +424,11 @@ LaTeX Package keymap for Linux
 
 	{
 		"keys": ["tab"],
-		"command": "latextools_confirm_quickpanel",
+		"command": "select",
 		"context": [
 			{ "key": "overlay_visible" },
-			{ "key": "latextools.input_overlay_visible" },
+			{ "key": "setting.auto_complete_commit_on_tab" },
+			{ "key": "latextools.input_overlay_visible" }
 		],
 	},
 

Default (OSX).sublime-keymap

@@ -424,10 +424,11 @@ LaTeX Package keymap for OS X
 
 	{
 		"keys": ["tab"],
-		"command": "latextools_confirm_quickpanel",
+		"command": "select",
 		"context": [
 			{ "key": "overlay_visible" },
-			{ "key": "latextools.input_overlay_visible" },
+			{ "key": "setting.auto_complete_commit_on_tab" },
+			{ "key": "latextools.input_overlay_visible" }
 		],
 	},
 

Default (Windows).sublime-keymap

@@ -424,10 +424,11 @@ LaTeX Package keymap for Linux
 
 	{
 		"keys": ["tab"],
-		"command": "latextools_confirm_quickpanel",
+		"command": "select",
 		"context": [
 			{ "key": "overlay_visible" },
-			{ "key": "latextools.input_overlay_visible" },
+			{ "key": "setting.auto_complete_commit_on_tab" },
+			{ "key": "latextools.input_overlay_visible" }
 		],
 	},
 

latextools/latex_fill_all.py

@@ -11,7 +11,6 @@
 from .utils.logging import logger
 from .utils.settings import get_setting
 from .utils.internal_types import FillAllHelper
-from .utils.input_quickpanel import show_input_quick_panel
 
 __all__ = [
     "LatexFillAllEventListener",
@@ -20,6 +19,8 @@
     "LatexToolsReplaceWord",
 ]
 
+VISIBLE_OVERLAYS = set()
+
 def reraise(tp, value, tb=None):
     if value is None:
         value = tp()
@@ -628,6 +629,14 @@ def on_query_context(self, view, key, operator, operand, match_all):
         key is "lt_fill_all_{name}" where name is the short name of the
         completion type, e.g. "lt_fill_all_cite", etc.
         """
+
+        # autofill input quick panel visible
+        if key == "latextools.input_overlay_visible":
+            try:
+                return view.window().id() in VISIBLE_OVERLAYS
+            except:
+                return False
+
         # quick exit conditions
         if not key.startswith("lt_fill_all_"):
             return None
@@ -991,8 +1000,13 @@ def run(self, edit, completion_type=None, insert_char="", overwrite=False, force
                 self.remove_regions(view, edit, remove_regions)
             self.clear_bracket_cache()
         else:
+            window = view.window()
+            if not window:
+                self.clear_bracket_cache()
+                return
 
             def on_done(i, text=""):
+                VISIBLE_OVERLAYS.discard(window.id())
                 if i is None:
                     insert_text = text
                 elif i < 0:
@@ -1019,7 +1033,10 @@ def on_done(i, text=""):
                         },
                     )
 
-            show_input_quick_panel(view.window(), formatted_completions, on_done)
+            # track visible input quick panels to provide key binding context
+            VISIBLE_OVERLAYS.add(window.id())
+            window.show_quick_panel(formatted_completions, on_done)
+
             self.clear_bracket_cache()
 
 

latextools/utils/input_quickpanel.py

@@ -138,10 +138,6 @@
     from .latextools.toggle_settings import (
         LatextoolsToggleKeysCommand
     )
-    from .latextools.utils.input_quickpanel import (
-        InputQuickpanelListener,
-        LatextoolsConfirmQuickpanelCommand
-    )
 
 
     def _filter_func(name):