Skip to content

First parameter of search $client->search->query should clearly accept FilterQuery #4

@g105b

Description

@g105b

At the moment, it just accepts a string, but FilterQuery is Stringable... but there's no way for the developer to know that.

public function query(
	FilterQuery|string $query,  // much better for self-documentation
	SearchFilter $searchType,
	?string $market = null,
	int $limit = 20,
	int $offset = 0,
	?string $includeExternal = null,
):SearchResult

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions