Extract helper method TAStudio.ToggleButtonStateOnFrames

Author: YoshiRulz

src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs

@@ -371,6 +371,78 @@ private bool TasView_QueryFrameLag(int index, bool hideWasLag)
 			return (lag.Lagged.HasValue && lag.Lagged.Value) || (hideWasLag && lag.WasLagged.HasValue && lag.WasLagged.Value);
 		}
 
+		/// <param name="selection">
+		/// list of row indices sorted ascending, as returned by <c>TasView.SelectedRows</c>,
+		/// and must not be empty (so there must be a selection)
+		/// </param>
+		/// <remarks>fills with <see langword="false"/> (unheld) if held on all selected frames, <see langword="true"/> (held) otherwise</remarks>
+		private void ToggleButtonStateOnFrames(int[] selection, string buttonName)
+		{
+			// nifty taseditor logic
+			// your TAS Editor logic failed us (it didn't account for non-contiguous `SelectedRows`) --yoshi
+			bool allPressed = true;
+			var contiguous = true;
+			var iSelection = 0;
+			var lastFrameIndexSeen = selection[iSelection] - 1;
+			while (iSelection < selection.Length)
+			{
+				var index = selection[iSelection];
+				if (index - lastFrameIndexSeen is not 1)
+				{
+					contiguous = false;
+					break;
+				}
+				lastFrameIndexSeen = index;
+				if (index == CurrentTasMovie.FrameCount // last movie frame can't have input, but can be selected
+					|| !CurrentTasMovie.BoolIsPressed(index, buttonName))
+				{
+					allPressed = false;
+					break;
+				}
+				iSelection++;
+			}
+			if (!allPressed)
+			{
+				// still need to check for discontinuity
+				while (iSelection < selection.Length)
+				{
+					var index = selection[iSelection];
+					if (index - lastFrameIndexSeen is not 1)
+					{
+						contiguous = false;
+						break;
+					}
+					lastFrameIndexSeen = index;
+					iSelection++;
+				}
+			}
+			else if (!contiguous)
+			{
+				// still need to check for `false` values
+				allPressed = allPressed && selection.Skip(iSelection - 1) // break'd before checking the next one, so less 1 (and can't get here if `iSelection` is 0 so that's safe)
+					.All(index => index < CurrentTasMovie.FrameCount // last movie frame can't have input, but can be selected
+						&& CurrentTasMovie.BoolIsPressed(index, buttonName));
+			}
+			// else all contiguous and all `true`
+
+			CurrentTasMovie.SetBoolStates(frame: selection[0], count: iSelection, buttonName, val: !allPressed);
+			var blockStart = iSelection;
+			lastFrameIndexSeen = selection[iSelection] - 1;
+			while (iSelection < selection.Length)
+			{
+				var index = selection[iSelection];
+				if (index - lastFrameIndexSeen is not 1)
+				{
+					// discontinuity; split off another block, and this is now the start of the next block
+					CurrentTasMovie.SetBoolStates(frame: selection[blockStart], count: iSelection - blockStart, buttonName, val: !allPressed);
+					blockStart = iSelection;
+				}
+				lastFrameIndexSeen = index;
+				iSelection++;
+			}
+			CurrentTasMovie.SetBoolStates(frame: selection[blockStart], count: iSelection - blockStart, buttonName, val: !allPressed);
+		}
+
 		private void TasView_ColumnClick(object sender, InputRoll.ColumnClickEventArgs e)
 		{
 			if (TasView.AnyRowsSelected)
@@ -389,70 +461,7 @@ private void TasView_ColumnClick(object sender, InputRoll.ColumnClickEventArgs e
 					{
 						if (ModifierKeys != Keys.Alt)
 						{
-							// nifty taseditor logic
-							// your TAS Editor logic failed us (it didn't account for non-contiguous `SelectedRows`) --yoshi
-							var selection = TasView.SelectedRows.ToArray(); // sorted asc, length >= 1
-							bool allPressed = true;
-							var contiguous = true;
-							var iSelection = 0;
-							var lastFrameIndexSeen = selection[iSelection] - 1;
-							while (iSelection < selection.Length)
-							{
-								var index = selection[iSelection];
-								if (index - lastFrameIndexSeen is not 1)
-								{
-									contiguous = false;
-									break;
-								}
-								lastFrameIndexSeen = index;
-								if (index == CurrentTasMovie.FrameCount // last movie frame can't have input, but can be selected
-									|| !CurrentTasMovie.BoolIsPressed(index, buttonName))
-								{
-									allPressed = false;
-									break;
-								}
-								iSelection++;
-							}
-							if (!allPressed)
-							{
-								// still need to check for discontinuity
-								while (iSelection < selection.Length)
-								{
-									var index = selection[iSelection];
-									if (index - lastFrameIndexSeen is not 1)
-									{
-										contiguous = false;
-										break;
-									}
-									lastFrameIndexSeen = index;
-									iSelection++;
-								}
-							}
-							else if (!contiguous)
-							{
-								// still need to check for `false` values
-								allPressed = allPressed && selection.Skip(iSelection - 1) // break'd before checking the next one, so less 1 (and can't get here if `iSelection` is 0 so that's safe)
-									.All(index => index < CurrentTasMovie.FrameCount // last movie frame can't have input, but can be selected
-										&& CurrentTasMovie.BoolIsPressed(index, buttonName));
-							}
-							// else all contiguous and all `true`
-
-							CurrentTasMovie.SetBoolStates(frame: selection[0], count: iSelection, buttonName, val: !allPressed);
-							var blockStart = iSelection;
-							lastFrameIndexSeen = selection[iSelection] - 1;
-							while (iSelection < selection.Length)
-							{
-								var index = selection[iSelection];
-								if (index - lastFrameIndexSeen is not 1)
-								{
-									// discontinuity; split off another block, and this is now the start of the next block
-									CurrentTasMovie.SetBoolStates(frame: selection[blockStart], count: iSelection - blockStart, buttonName, val: !allPressed);
-									blockStart = iSelection;
-								}
-								lastFrameIndexSeen = index;
-								iSelection++;
-							}
-							CurrentTasMovie.SetBoolStates(frame: selection[blockStart], count: iSelection - blockStart, buttonName, val: !allPressed);
+							ToggleButtonStateOnFrames(TasView.SelectedRows.ToArray(), buttonName);
 						}
 						else
 						{