Skip to content

Warn the user before closing if the cycle count won't be saved properly #2341

@RetroEdit

Description

@RetroEdit

Similar to #2203, but distinct. Generally, TASers will want to know if the cycle count for Game Boy movies will not be saved properly, since it's the most precise mechanism for timing. The only way to calculate the cycle count is to emulate to the end of the movie (because VBLANK frames on Game Boy can have differing amount of cycles).

With my changes in #2337, this is slightly improved because the cycle count will then only be saved if it's guaranteed to be valid. However, this still doesn't prevent the user from forgetting to seek to the end of the movie to save the cycle count, it only prevents them from saving the wrong cycle count by instead saving no cycle count at all.

Note: we could also provide an option in the nag UI to have the movie session automatically seek to the end of the movie and save the cycle count. This would make saving it properly very convenient for the user.

In IRC, this was discussed, and I don't think it's necessarily a good idea for 2.5 at this point, but I think it's worth considering for the future.


More specifically, this is not a simple as it may first seem:

  • Nagging the user about cores where the cycle count can be inferred from the frame count seems annoying and pointless. If more cores expose their cycle count in the future, this doesn't mean the user needs to be nagged about not reaching the end of the movie for those cores.
  • Every exit-based interaction like this can become complicated. For instance, how is importing into TAStudio from a current movie session going to be handled?

Metadata

Metadata

Assignees

No one assigned

    Labels

    App: EmuHawkRelating to EmuHawk frontend

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions