Skip to content

Commit d5dcdd4

Browse files
fix: removed redundant caching in server extension
1 parent 98716aa commit d5dcdd4

File tree

2 files changed

+1
-15
lines changed

2 files changed

+1
-15
lines changed

grader_labextension/handlers/permission.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import json
88
from grader_labextension.registry import register_handler
9-
from grader_labextension.handlers.base_handler import ExtensionBaseHandler, cache
9+
from grader_labextension.handlers.base_handler import ExtensionBaseHandler
1010
from tornado.web import HTTPError, authenticated
1111
from grader_labextension.services.request import RequestServiceError
1212

@@ -17,8 +17,6 @@ class PermissionBaseHandler(ExtensionBaseHandler):
1717
Tornado Handler class for http requests to /permissions.
1818
"""
1919
@authenticated
20-
@cache(max_age=10)
21-
@authenticated
2220
async def get(self):
2321
""" Sends a GET-request to the grader service and returns the permissions of a user
2422
"""

grader_labextension/services/request.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
from tornado.httpclient import AsyncHTTPClient, HTTPRequest, HTTPResponse, HTTPError
77
from traitlets import Unicode, TraitError, validate
88
from traitlets.config import SingletonConfigurable
9-
from cachetools import TTLCache
109

1110
class RequestServiceError(Exception):
1211
def __init__(self, code: int, status_text: str, message: str):
@@ -26,8 +25,6 @@ def __init__(
2625
self,
2726
default_request_timeout: float = 20.0,
2827
default_connect_timeout: float = 20.0,
29-
cache_ttl: int = 60, # Time-to-live for cached responses in seconds
30-
max_cache_size: int = 100, # Maximum number of cached responses
3128
max_retries: int = 3, # Max retry attempts for transient errors
3229
**kwargs
3330
):
@@ -37,7 +34,6 @@ def __init__(
3734
self.default_request_timeout = default_request_timeout
3835
self.default_connect_timeout = default_connect_timeout
3936
self.max_retries = max_retries
40-
self.cache = TTLCache(maxsize=max_cache_size, ttl=cache_ttl)
4137

4238
def get_authorization_header(self):
4339
auth_token = os.environ.get("GRADER_API_TOKEN")
@@ -115,11 +111,6 @@ async def request(
115111
if isinstance(body, dict):
116112
body = json.dumps(body)
117113

118-
cache_key = f"{method}:{endpoint}"
119-
if method == "GET" and cache_key in self.cache:
120-
self.log.info(f"Returning cached response for {endpoint}")
121-
return self.cache[cache_key]
122-
123114
request = HTTPRequest(
124115
url=self.url + endpoint,
125116
method=method,
@@ -137,9 +128,6 @@ async def request(
137128
else:
138129
response_data = response
139130

140-
if method == "GET":
141-
self.cache[cache_key] = response_data
142-
143131
if response_callback:
144132
response_callback(response)
145133

0 commit comments

Comments
 (0)