[TASK] Improve stdWrap.formattedDate #1344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An example for a custom date/time format derived from a timestamp has been added. Additionally, add a heading for each example to improve readability. Releases: main, 12.4
froemken
approved these changes
Sep 26, 2024
Contributor
froemken
left a comment
froemken
left a comment
There was a problem hiding this comment.
Thank you for your patch.
Some marks:
Normally we have 2 whitespaces indent for TypoScript, but as all other examples in that file have 4 whitespaces, it's OK for me.
I have tested your snippet. For me it's 2023-03-17T04:00:00+0100. Seems you're living at greenwich timezone ;-)
Contributor
Author
|
My ddev is set up with UTC. |
Contributor
Author
|
About the indentation: I adopted the indents from the example above. |
Member
|
@froemken I just noticed, that the .editorconfig is incomplete. Introducing a propper .editorconfig would therefore be a follow up. |
linawolf
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example for a custom date/time format derived from a timestamp has been added as a showcase.
Additionally, add a heading for each example to improve readability.
Releases: main, 12.4