Fix not valid selection index when the user clicks between the last item and the ListBox end

victorlevasseur · victorlevasseur · commit 603ecc3373c0 · 2016-02-24T17:39:44.000+01:00
diff --git a/src/SFGUI/ListBox.cpp b/src/SFGUI/ListBox.cpp
@@ -414,7 +414,7 @@ ListBox::IndexType ListBox::GetItemAt( float y ) const {
 	else if( item_index > m_max_displayed_items_count )
 		return NONE;
 	else
-		return item_index - 1 + m_first_displayed_item;
+		return std::min(item_index - 1 + m_first_displayed_item, GetItemsCount() - 1);
 }
 
 bool ListBox::IsScrollbarVisible() const {

Original file line number	Diff line number	Diff line change
`@@ -414,7 +414,7 @@ ListBox::IndexType ListBox::GetItemAt( float y ) const {`
`414`	`414`	`else if( item_index > m_max_displayed_items_count )`
`415`	`415`	`return NONE;`
`416`	`416`	`else`
`417`		`- return item_index - 1 + m_first_displayed_item;`
	`417`	`+ return std::min(item_index - 1 + m_first_displayed_item, GetItemsCount() - 1);`
`418`	`418`	`}`
`419`	`419`
`420`	`420`	`bool ListBox::IsScrollbarVisible() const {`