No more fakes

[joanhey]

Please, no more http: length hard encoded.

No more template response cache !!!
The template is OK to cache, but the response for the fortunes is NOT OK.

#9560 (comment)

[remittor]

mrhttp also non realistic implementation: #9055

[joanhey]

Now the devs of the framework decide if it's realistic or not.

We need to implement more tests before start the benchmark !!

#9440 (comment)

[p8]

The template is OK to cache, but the response for the fortunes is NOT OK.

I wonder if we should make fortunes response dynamic to prevent this.
Maybe store more fortunes in the database and pick random fortunes, similar to the query test?

[joanhey]

Validate response status codes #9605

[joanhey]

Shouldn't pre-computed HTTP headers trigger "Stripped" classification? #8205

[joanhey]

@p8 #9578 (comment)
#6529
#6788
#6883

[p8]

The aspnetcore framework precomputes the header length as well:

FrameworkBenchmarks/frameworks/CSharp/aspnetcore-mono/PlatformBenchmarks/BenchmarkApplication.Json.cs

Lines 14 to 18 in c82a834

	private readonly static AsciiString _jsonPreamble =
	_http11OK +
	_headerServer + _crlf +
	_headerContentTypeJson + _crlf +
	_headerContentLength + _jsonPayloadSize.ToString();

FrameworkBenchmarks/frameworks/CSharp/aspnetcore-mono/PlatformBenchmarks/BenchmarkApplication.Json.cs

Line 12 in c82a834

private readonly static uint _jsonPayloadSize = (uint)JsonSerializer.SerializeToUtf8Bytes(new JsonMessage { message = "Hello, World!" }, SerializerOptions).Length;

FrameworkBenchmarks/frameworks/CSharp/aspnetcore/src/Platform/BenchmarkApplication.Plaintext.cs

Lines 13 to 16 in c82a834

	"HTTP/1.1 200 OK\r\n"u8 +
	"Server: K\r\n"u8 +
	"Content-Type: text/plain\r\n"u8 +
	"Content-Length: 13"u8;

[remittor]

aspnetcore

image

FrameworkBenchmarks/frameworks/CSharp/aspnetcore/src/Platform/BenchmarkApplication.Json.cs

Lines 19 to 23 in c82a834

	private static ReadOnlySpan<byte> _jsonPreamble =>
	"HTTP/1.1 200 OK\r\n"u8 +
	"Server: K\r\n"u8 +
	"Content-Type: application/json\r\n"u8 +
	"Content-Length: 27"u8;

The benchmark uses a custom implementation of the Date header generation:

FrameworkBenchmarks/frameworks/CSharp/aspnetcore/src/Platform/BenchmarkApplication.Json.cs

Lines 25 to 30 in c82a834

	private static void Json(ref BufferWriter<WriterAdapter> writer, IBufferWriter<byte> bodyWriter)
	{
	writer.Write(_jsonPreamble);
	// Date header
	writer.Write(DateHeader.HeaderBytes);

But in fact, we should test the implementation that comes with the original framework:

https://github.com/dotnet/aspnetcore/blob/main/src/Servers/Kestrel/Core/src/Internal/Http/DateHeaderValueManager.cs

https://github.com/dotnet/aspnetcore/blob/8645583a97fa8140da0a588bbd00c5e9cf13983c/src/Servers/Kestrel/Core/src/Internal/Http/HttpProtocol.cs#L1263-L1269