Skip to content

Move to having two reviewers for pull requests? #350

@dstansby

Description

@dstansby

What needs to be done?

Now we have a pretty established package and set of docs, I was wondering what people think of going up from requiring one approval to two approvals on pull requests? My thinking is that:

  • It would give a second pair of eyes on stuff to make sure anything we add to the docs has slightly wider agreement
  • Getting other folks to review/approve changes or additions to the docs might be a nice low-effort/low barrier to entry way of getting more people involved in this project?

It would slow down how fast things are merged, but I think that the project as a whole is now mature enough that that shouldn't be too much of an issue.

Thoughts?

Metadata

Metadata

Assignees

Labels

taskA task to be completed with the repo

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions