From a6bb85021da896ffdbbd7bffed41251abd80ef11 Mon Sep 17 00:00:00 2001 From: tsanislavgatev Date: Thu, 20 Nov 2025 17:27:03 +0200 Subject: [PATCH 1/4] feat(ui5-button): add getter --- packages/main/src/Button.ts | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/packages/main/src/Button.ts b/packages/main/src/Button.ts index 065fd36eb9e4..bba014ba89f1 100644 --- a/packages/main/src/Button.ts +++ b/packages/main/src/Button.ts @@ -658,6 +658,20 @@ class Button extends UI5Element implements IButton { }; } + get accessibilityInfo() { + return { + ariaExpanded: this.accessibilityAttributes.expanded, + ariaHasPopup: this.accessibilityAttributes.hasPopup, + ariaControls: this.accessibilityAttributes.controls, + ariaKeyShortcuts: this.accessibilityAttributes.ariaKeyShortcuts, + ariaLabel: this.accessibilityAttributes.ariaLabel || this.ariaLabelText, + ariaDescription: this.ariaDescriptionText, + role: this.effectiveAccRole, + disabled: this.disabled, + tabIndex: this.tabIndexValue, + }; + } + get effectiveBadgeDescriptionText() { if (!this.shouldRenderBadge) { return ""; From 9e1854aa2296a8ec1f3b8decb1e9cf38dab9eb7e Mon Sep 17 00:00:00 2001 From: tsanislavgatev Date: Fri, 21 Nov 2025 14:43:05 +0200 Subject: [PATCH 2/4] fix(ui5-button): use correct format --- packages/main/src/Button.ts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/packages/main/src/Button.ts b/packages/main/src/Button.ts index bba014ba89f1..ffd3b3dcff7d 100644 --- a/packages/main/src/Button.ts +++ b/packages/main/src/Button.ts @@ -660,15 +660,9 @@ class Button extends UI5Element implements IButton { get accessibilityInfo() { return { - ariaExpanded: this.accessibilityAttributes.expanded, - ariaHasPopup: this.accessibilityAttributes.hasPopup, - ariaControls: this.accessibilityAttributes.controls, - ariaKeyShortcuts: this.accessibilityAttributes.ariaKeyShortcuts, - ariaLabel: this.accessibilityAttributes.ariaLabel || this.ariaLabelText, - ariaDescription: this.ariaDescriptionText, + description: this.ariaDescriptionText, role: this.effectiveAccRole, disabled: this.disabled, - tabIndex: this.tabIndexValue, }; } From 30e24e0a44319bffcec77a2bad85eff63d64bc60 Mon Sep 17 00:00:00 2001 From: tsanislavgatev Date: Tue, 25 Nov 2025 13:14:59 +0200 Subject: [PATCH 3/4] feat(ui5-button): add test --- packages/main/cypress/specs/Button.cy.tsx | 57 +++++++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/packages/main/cypress/specs/Button.cy.tsx b/packages/main/cypress/specs/Button.cy.tsx index 2587893a438b..b0dc10aa84eb 100644 --- a/packages/main/cypress/specs/Button.cy.tsx +++ b/packages/main/cypress/specs/Button.cy.tsx @@ -577,4 +577,61 @@ describe("Accessibility", () => { cy.get("@tag") .should("have.text", "999+"); }); + + it("accessibilityInfo returns correct properties for different button states", () => { + cy.mount(); + + cy.get); + + cy.get); + + cy.get