From 27f2b296b6cde62e2eca8041c813bb94f8424e36 Mon Sep 17 00:00:00 2001 From: Peter Smith Date: Wed, 7 Jun 2023 12:00:10 +1000 Subject: [PATCH 1/2] Fixing infinite recursive call. --- .../Runtime/Messages/HandwrittenMessages/msg/TimeMsg.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/com.unity.robotics.ros-tcp-connector/Runtime/Messages/HandwrittenMessages/msg/TimeMsg.cs b/com.unity.robotics.ros-tcp-connector/Runtime/Messages/HandwrittenMessages/msg/TimeMsg.cs index 0046259e..380055b1 100644 --- a/com.unity.robotics.ros-tcp-connector/Runtime/Messages/HandwrittenMessages/msg/TimeMsg.cs +++ b/com.unity.robotics.ros-tcp-connector/Runtime/Messages/HandwrittenMessages/msg/TimeMsg.cs @@ -64,7 +64,7 @@ public override string ToString() // for convenience when writing ROS2 agnostic code public uint secs { get => (uint)sec; set => sec = (int)value; } - public uint nsecs { get => nsecs; set => nsecs = value; } + public uint nsecs { get => nanosec; set => nanosec = value; } public TimeMsg() { From 99d6a336da8722ae377258206af0b136d1ab07d1 Mon Sep 17 00:00:00 2001 From: Peter Smith Date: Wed, 7 Jun 2023 12:04:46 +1000 Subject: [PATCH 2/2] Updating CHANGELOG.md with TimeMsg nsecs bug fix. --- com.unity.robotics.ros-tcp-connector/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/com.unity.robotics.ros-tcp-connector/CHANGELOG.md b/com.unity.robotics.ros-tcp-connector/CHANGELOG.md index f883a80f..c0d9499a 100644 --- a/com.unity.robotics.ros-tcp-connector/CHANGELOG.md +++ b/com.unity.robotics.ros-tcp-connector/CHANGELOG.md @@ -21,6 +21,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a ### Fixed +Fixing bug in ROS2 where the getter TimeMsg nsecs caused a StackOverflowException + ## [0.7.0-preview] - 2022-02-01