Skip to content

Commit 50941df

Browse files
committed
Resolved issues following merge
1 parent 3f7c495 commit 50941df

File tree

6 files changed

+30
-7
lines changed

6 files changed

+30
-7
lines changed

src/main/java/de/vill/model/building/AutomaticBrackets.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ private AutomaticBrackets() {}
5454
expressionPrecedenceLookup.put(MaxAggregateFunctionExpression.class, 2);
5555
expressionPrecedenceLookup.put(MinAggregateFunctionExpression.class, 2);
5656
expressionPrecedenceLookup.put(SumAggregateFunctionExpression.class, 2);
57-
expressionPrecedenceLookup.put(ParenthesisConstraint.class, 2);
57+
expressionPrecedenceLookup.put(ParenthesisExpression.class, 2);
5858

5959
expressionPrecedenceLookup.put(LiteralExpression.class, 2);
6060
expressionPrecedenceLookup.put(NumberExpression.class, 2);

src/main/java/de/vill/model/expression/AggregateFunctionExpression.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,21 @@
1111
import java.util.Objects;
1212
import java.util.Set;
1313

14-
import static de.vill.util.Util.addNecessaryQuotes;
1514
public abstract class AggregateFunctionExpression extends Expression {
1615

1716
protected GlobalAttribute attribute;
1817
protected Feature rootFeature;
1918

19+
20+
public AggregateFunctionExpression(GlobalAttribute attribute) {
21+
this.attribute = attribute;
22+
}
23+
24+
public AggregateFunctionExpression(GlobalAttribute attribute, Feature rootFeature) {
25+
this(attribute);
26+
this.rootFeature = rootFeature;
27+
}
28+
2029
@Override
2130
public String toString(boolean withSubmodels, String currentAlias) {
2231
return toString(withSubmodels, "aggregateFunction", currentAlias);
@@ -98,9 +107,4 @@ public boolean equals(Object obj) {
98107
public List<VariableReference> getReferences() {
99108
return List.of(attribute);
100109
}
101-
102-
@Override
103-
public Expression clone(){
104-
return new AggregateFunctionExpression(attribute, rootFeature);
105-
}
106110
}

src/main/java/de/vill/model/expression/AvgAggregateFunctionExpression.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,9 @@ public List<Expression> getExpressionSubParts() {
5151
public String getReturnType() {
5252
return Constants.NUMBER;
5353
}
54+
55+
@Override
56+
public Expression clone() {
57+
return new AvgAggregateFunctionExpression(attribute, rootFeature);
58+
}
5459
}

src/main/java/de/vill/model/expression/MaxAggregateFunctionExpression.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,9 @@ public String getReturnType() {
5151
public List<Expression> getExpressionSubParts() {
5252
return Arrays.asList();
5353
}
54+
55+
@Override
56+
public Expression clone() {
57+
return new MaxAggregateFunctionExpression(attribute, rootFeature);
58+
}
5459
}

src/main/java/de/vill/model/expression/MinAggregateFunctionExpression.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,4 +52,9 @@ public String getReturnType() {
5252
public List<Expression> getExpressionSubParts() {
5353
return Arrays.asList();
5454
}
55+
56+
@Override
57+
public Expression clone() {
58+
return new MinAggregateFunctionExpression(attribute, rootFeature);
59+
}
5560
}

src/main/java/de/vill/model/expression/SumAggregateFunctionExpression.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,8 @@ public List<Expression> getExpressionSubParts() {
4949
public String getReturnType() {
5050
return Constants.NUMBER;
5151
}
52+
@Override
53+
public Expression clone() {
54+
return new SumAggregateFunctionExpression(attribute, rootFeature);
55+
}
5256
}

0 commit comments

Comments
 (0)