feat(and-constraint): allow more than two children #24
+138
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SundermannC
requested changes
Oct 27, 2025
Member
SundermannC
left a comment
SundermannC
left a comment
There was a problem hiding this comment.
Looks good overall, thanks a lot! I have small inline suggestions. I think we should also merge MultiAnd and And classes to reflect the same behavior in this PR.
.DS_Store
Outdated
Member
There was a problem hiding this comment.
These files should never be added. Should be removed and generally added to .gitignore.
| } | ||
| } | ||
|
|
||
| public Constraint getLeft() { |
Member
There was a problem hiding this comment.
For backwards compatibility, it may make sense to leave those and make them return the first and last element of the list respectively (same behavior as before when using the left/right constructor)
| @Override | ||
| public List<Constraint> getConstraintSubParts() { | ||
| return Arrays.asList(left, right); | ||
| return new ArrayList<>(children); |
Member
There was a problem hiding this comment.
Why do we need a new list here? Can we just return children?
added 5 commits
November 21, 2025 18:12
…t for backwards compatibility and deleted the .DS files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.