Skip to content

Commit 891a396

Browse files
committed
fix gemspec
- appease rubocop - more fixes apparently i don't run all tests in all platforms locally
1 parent c4b8728 commit 891a396

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

Steepfile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,14 @@ D = Steep::Diagnostic
33
target :lib do
44
signature "*.rbs"
55

6+
# NOTE: All client-exposed methods/types should now have type signatures / rbs support
67
check "lib/unleash/client.rb"
78
check "lib/unleash/context.rb"
9+
check "lib/unleash/variant.rb"
810
check "lib/unleash/scheduled_executor.rb"
911

12+
# TODO: add signatures to the rest
13+
# Mostly internal SDK files.
1014
ignore "lib/unleash/bootstrap"
1115
ignore "lib/unleash/strategy/*.rb"
1216
ignore "lib/unleash/util"

unleash-client.gemspec

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,11 @@ Gem::Specification.new do |spec|
4040
spec.add_development_dependency "simplecov", "~> 0.21.2"
4141
spec.add_development_dependency "simplecov-lcov", "~> 0.8.0"
4242

43-
spec.add_development_dependency "rbs", "~> 2.7"
44-
spec.add_development_dependency "steep", "~> 1.2"
43+
# NOTE: only require rbs/steep in supported ruby versions. In EOL ruby/jruby, just ignore.
44+
# rubocop:disable Gemspec/RubyVersionGlobalsUsage
45+
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.6') && RUBY_ENGINE != 'jruby'
46+
spec.add_development_dependency "rbs", "~> 2.8"
47+
spec.add_development_dependency "steep", "~> 1.3"
48+
end
49+
# rubocop:enable Gemspec/RubyVersionGlobalsUsage
4550
end

0 commit comments

Comments
 (0)