Skip to content

Commit 4541f37

Browse files
Release 1.0.11
⬆️ Bump SDK version 👔 Update business logic for fake reload after update user properties 🐛 prevent duplicated identify event 💄 Enhance UI content margins ✅ Update unit tests for app state in session monitor 🦺 Enhance handling pending experiences 🦺 Remove force unwrap 🐛 Fix process pending content 🦺 Include seen event for update seen content 🦺 Request screen event after back from background when active content appears 📝 Update docs and comments for ExperiencesPublisher & AnalyticsPublisher 🦺 Update flush queue logic for logout ✅ Update Unit tests 💄 Rename methods
1 parent 731eda9 commit 4541f37

File tree

19 files changed

+650
-387
lines changed

19 files changed

+650
-387
lines changed

Sample/UserpilotSwiftSample/UserpilotSample.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -923,7 +923,7 @@
923923
"$(inherited)",
924924
"@executable_path/Frameworks",
925925
);
926-
MARKETING_VERSION = 1.0.10;
926+
MARKETING_VERSION = 1.0.11;
927927
PRODUCT_BUNDLE_IDENTIFIER = com.userpilot.sample.dev;
928928
PRODUCT_NAME = "$(TARGET_NAME)";
929929
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -958,7 +958,7 @@
958958
"$(inherited)",
959959
"@executable_path/Frameworks",
960960
);
961-
MARKETING_VERSION = 1.0.10;
961+
MARKETING_VERSION = 1.0.11;
962962
PRODUCT_BUNDLE_IDENTIFIER = com.userpilot.sample;
963963
PRODUCT_NAME = "$(TARGET_NAME)";
964964
PROVISIONING_PROFILE_SPECIFIER = "";

Sample/UserpilotSwiftSample/UserpilotSample/CustomViews/PropertyView/PropertyView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class PropertyView: UIView, NibLoadable {
4141
}
4242

4343
// MARK: - Helper methods
44-
func bindData(propertyName: String, propertyValue: String) {
44+
func bindData(propertyName: String, propertyValue: String?) {
4545
self.propertyName.text = propertyName
4646
self.propertyValue.text = propertyValue
4747
}

Sample/UserpilotSwiftSample/UserpilotSample/Dialogs/Properties/AddPropertyDialogViewController.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ class AddPropertyDialogViewController: UIViewController {
2727

2828
private var propertyTitleData: String?
2929
private var propertyValueData: String?
30-
private var doneButtonHandler: ((String, String) -> Void)?
30+
private var doneButtonHandler: ((String, String?) -> Void)?
3131

3232
// MARK: - Initialization
3333

34-
public init(propertyTitle: String, propertyValue: String, doneButtonHandler: ((String, String) -> Void)?) {
34+
public init(propertyTitle: String, propertyValue: String, doneButtonHandler: ((String, String?) -> Void)?) {
3535
super.init(nibName: "AddPropertyDialogViewController", bundle: nil)
3636

3737
self.propertyTitleData = propertyTitle
@@ -84,7 +84,7 @@ class AddPropertyDialogViewController: UIViewController {
8484
func executeDoneButtonHandler() {
8585
if self.doneButtonHandler != nil,
8686
let propertyTitle = propertyTitle.text, !propertyTitle.isEmpty,
87-
let propertyValue = propertyValue.text, !propertyValue.isEmpty {
87+
let propertyValue = propertyValue.text {
8888
self.doneButtonHandler!(propertyTitle, propertyValue)
8989
}
9090
dismiss(animated: true)

Sample/UserpilotSwiftSample/UserpilotSample/Featues/Events/CustomEvent/CustomEventViewController.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,15 +69,15 @@ extension CustomEventViewController {
6969
extension CustomEventViewController {
7070

7171
internal func showAddEventPropertyDiaog(_ propertyTitle: String = "", _ propertyValue: String = "") {
72-
DialogManager.shared().showAPIAlertDialog(propertyTitle: propertyTitle,
72+
DialogManager.shared().showAddPropertyDialogViewController(propertyTitle: propertyTitle,
7373
propertyValue: propertyValue,
7474
doneButtonHandler: { [weak self] propertyTitle, propertyValue in
7575
guard let self else { return }
7676
self.addUserProperty(propertyTitle, propertyValue)
7777
})
7878
}
7979

80-
private func addUserProperty(_ propertyTitle: String, _ propertyValue: String) {
80+
private func addUserProperty(_ propertyTitle: String, _ propertyValue: String?) {
8181
let propertyView = PropertyView()
8282

8383
propertyView.onEditProperty = { [weak self] propertyTitle, propertyValue in

Sample/UserpilotSwiftSample/UserpilotSample/Featues/Identify/Extensions/IdentifyViewController+CompanyProperties.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ import Foundation
1212
extension IdentifyViewController {
1313

1414
internal func showAddCompanyPropertyDialog(_ propertyTitle: String = "", _ propertyValue: String = "") {
15-
DialogManager.shared().showAPIAlertDialog(propertyTitle: propertyTitle,
15+
DialogManager.shared().showAddPropertyDialogViewController(propertyTitle: propertyTitle,
1616
propertyValue: propertyValue,
1717
doneButtonHandler: { [weak self] propertyTitle, propertyValue in
1818
guard let self else { return }
1919
self.addCompanyProperty(propertyTitle, propertyValue)
2020
})
2121
}
2222

23-
private func addCompanyProperty(_ propertyTitle: String, _ propertyValue: String) {
23+
private func addCompanyProperty(_ propertyTitle: String, _ propertyValue: String?) {
2424
let propertyView = PropertyView()
2525

2626
propertyView.onEditProperty = { [weak self] propertyTitle, propertyValue in

Sample/UserpilotSwiftSample/UserpilotSample/Featues/Identify/Extensions/IdentifyViewController+UserProperties.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ import Foundation
1212
extension IdentifyViewController {
1313

1414
internal func showAddUserPropertyDiaog(_ propertyTitle: String = "", _ propertyValue: String = "") {
15-
DialogManager.shared().showAPIAlertDialog(propertyTitle: propertyTitle,
15+
DialogManager.shared().showAddPropertyDialogViewController(propertyTitle: propertyTitle,
1616
propertyValue: propertyValue,
1717
doneButtonHandler: { [weak self] propertyTitle, propertyValue in
1818
guard let self else { return }
1919
self.addUserProperty(propertyTitle, propertyValue)
2020
})
2121
}
2222

23-
private func addUserProperty(_ propertyTitle: String, _ propertyValue: String) {
23+
private func addUserProperty(_ propertyTitle: String, _ propertyValue: String?) {
2424
let propertyView = PropertyView()
2525

2626
propertyView.onEditProperty = { [weak self] propertyTitle, propertyValue in

Sample/UserpilotSwiftSample/UserpilotSample/Managers/UI/DialogManager.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ class DialogManager {
2727
}
2828

2929
// MARK: - Alert Dialog
30-
func showAPIAlertDialog(propertyTitle: String,
31-
propertyValue: String,
32-
doneButtonHandler: ((String, String) -> Void)?) {
30+
func showAddPropertyDialogViewController(propertyTitle: String,
31+
propertyValue: String,
32+
doneButtonHandler: ((String, String?) -> Void)?) {
3333

3434
let dialog = AddPropertyDialogViewController(
3535
propertyTitle: propertyTitle,

0 commit comments

Comments
 (0)