Merge pull request #1107 from adamtheturtle/capture-target-id

Add target ID property to UnknownTarget exception

Author: adamtheturtle

src/vws/exceptions.py

@@ -1,6 +1,7 @@
 """
 Custom exceptions for Vuforia errors.
 """
+from urllib.parse import urlparse
 
 import requests
 from requests import Response
@@ -89,6 +90,16 @@ def response(self) -> Response:
         """
         return self._response
 
+    @property
+    def target_id(self) -> str:
+        """
+        The unknown target ID.
+        """
+        path = urlparse(self.response.url).path
+        # Every HTTP path which can raise this error is in the format
+        # `/something/{target_id}`.
+        return path.split(sep='/', maxsplit=2)[-1]
+
 
 class Fail(Exception):
     """

tests/test_exceptions.py

@@ -49,14 +49,16 @@ def test_image_too_large(
     assert exc.value.response.status_code == codes.UNPROCESSABLE_ENTITY
 
 
-def test_invalid_given_id(vws_client: VWS) -> None:
+@pytest.mark.parametrize('target_id', ['x', 'x/1'])
+def test_invalid_given_id(vws_client: VWS, target_id: str) -> None:
     """
     Giving an invalid ID to a helper which requires a target ID to be given
     causes an ``UnknownTarget`` exception to be raised.
     """
     with pytest.raises(UnknownTarget) as exc:
-        vws_client.delete_target(target_id='x')
+        vws_client.delete_target(target_id=target_id)
     assert exc.value.response.status_code == codes.NOT_FOUND
+    assert exc.value.target_id == target_id
 
 
 def test_add_bad_name(vws_client: VWS, high_quality_image: io.BytesIO) -> None: