Do not encode application metadata as base64 - require user to do that

Author: adamtheturtle

src/vws/vws.py

@@ -475,7 +475,7 @@ def update_target(
         width: Optional[Union[int, float]] = None,
         image: Optional[io.BytesIO] = None,
         active_flag: Optional[bool] = None,
-        application_metadata: Optional[bytes] = None,
+        application_metadata: Optional[str] = None,
     ) -> None:
         """
         Add a target to a Vuforia Web Services database.
@@ -491,8 +491,11 @@ def update_target(
             image: The image of the target.
             active_flag: Whether or not the target is active for query.
             application_metadata: The application metadata of the target.
-                This will be base64 encoded. Giving ``None`` will not change
-                the application metadata.
+                This must be base64 encoded, for example by using::
+
+                    base64.b64encode('input_string').decode('ascii')
+
+                Giving ``None`` will not change the application metadata.
 
         Raises:
             ~vws.exceptions.AuthenticationFailure: The secret key is not
@@ -528,9 +531,7 @@ def update_target(
             data['active_flag'] = active_flag
 
         if application_metadata is not None:
-            metadata_encoded_str = base64.b64encode(application_metadata)
-            metadata_encoded = metadata_encoded_str.decode('ascii')
-            data['application_metadata'] = metadata_encoded
+            data['application_metadata'] = application_metadata
 
         content = bytes(json.dumps(data), encoding='utf-8')
 

tests/test_vws.py

@@ -493,7 +493,7 @@ def test_update_target(
             width=2,
             active_flag=False,
             image=image_file_failed_state,
-            application_metadata=b'a',
+            application_metadata=base64.b64encode(b'a').decode('ascii'),
         )
 
         vws_client.wait_for_target_processed(target_id=target_id)