Skip to content

Commit c3bd54b

Browse files
author
Fergus Dixon
committed
another bash at this, and revert changes made in 0.1.1
1 parent 229de5a commit c3bd54b

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

Cargo.toml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,16 @@ axum = ["dep:axum", "dep:tokio", "dep:axum-tracing-opentelemetry"]
1717

1818
[dependencies]
1919
axum = { version = "^0.6.10", optional = true }
20-
axum-tracing-opentelemetry = { version = "^0.14.1", optional = true }
20+
axum-tracing-opentelemetry = { version = "0.18.0", optional = true }
2121
chrono = "^0.4.24"
22-
opentelemetry = { version = "^0.20.0", features = ["rt-tokio"] }
23-
opentelemetry-datadog = "^0.8.0"
24-
opentelemetry-otlp = { version = "^0.13.0" }
22+
opentelemetry = { version = "0.22.0" }
23+
opentelemetry-datadog = "0.10.0"
24+
opentelemetry-otlp = { version = "0.15.0" , features = ["tls", "tls-roots"]}
25+
opentelemetry_sdk = { version = "0.22.0", features = ["rt-tokio"] }
2526
serde = { version = "^1.0.156", features = ["derive"] }
2627
serde_json = "^1.0.95"
2728
tokio = { version = "^1.26.0", features = ["signal"], optional = true }
2829
tracing = "^0.1.37"
29-
tracing-opentelemetry = "^0.21.0"
30+
tracing-opentelemetry = "0.23.0"
3031
tracing-serde = "^0.1.3"
3132
tracing-subscriber = { version = "^0.3.16", features = ["env-filter", "json"] }

src/formatter.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
use std::io;
99

1010
use chrono::Utc;
11+
use opentelemetry::trace::TraceContextExt;
1112
use opentelemetry::trace::{SpanId, TraceId};
1213
use serde::ser::{SerializeMap, Serializer as _};
1314
use serde::Serialize;
@@ -45,7 +46,7 @@ where
4546
S: Subscriber + for<'a> LookupSpan<'a>,
4647
{
4748
span_ref.extensions().get::<OtelData>().map(|o| TraceInfo {
48-
trace_id: o.builder.trace_id.unwrap_or(TraceId::INVALID).into(),
49+
trace_id: o.parent_cx.span().span_context().trace_id().into(),
4950
span_id: o.builder.span_id.unwrap_or(SpanId::INVALID).into(),
5051
})
5152
}

src/tracer.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
//! to send traces to the Datadog agent in batches over gRPC.
55
//!
66
//! It also contains a convenience function to build a layer with the tracer.
7-
use opentelemetry::sdk::trace::{RandomIdGenerator, Sampler, Tracer};
8-
use opentelemetry::sdk::{trace, Resource};
97
pub use opentelemetry::trace::{TraceError, TraceResult};
108
use opentelemetry::KeyValue;
119
use opentelemetry_otlp::WithExportConfig;
10+
use opentelemetry_sdk::trace::{RandomIdGenerator, Sampler, Tracer};
11+
use opentelemetry_sdk::{trace, Resource};
1212
use std::time::Duration;
1313
use tracing::Subscriber;
1414
use tracing_opentelemetry::{OpenTelemetryLayer, PreSampledTracer};
@@ -18,7 +18,6 @@ pub fn build_tracer(service_name: &str) -> TraceResult<Tracer> {
1818
let exporter = opentelemetry_otlp::new_exporter()
1919
.tonic()
2020
.with_timeout(Duration::from_secs(3));
21-
2221
opentelemetry_otlp::new_pipeline()
2322
.tracing()
2423
.with_trace_config(
@@ -31,7 +30,7 @@ pub fn build_tracer(service_name: &str) -> TraceResult<Tracer> {
3130
.with_id_generator(RandomIdGenerator::default()),
3231
)
3332
.with_exporter(exporter)
34-
.install_batch(opentelemetry::runtime::Tokio)
33+
.install_batch(opentelemetry_sdk::runtime::Tokio)
3534
}
3635

3736
pub fn build_layer<S>(service_name: &str) -> TraceResult<OpenTelemetryLayer<S, Tracer>>

0 commit comments

Comments
 (0)