[TF2] Make baseball/ornament appearance and behavior consistent when reflected #1651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Wrap Assassin's ornament is reflected by an enemy, it changes its color to that of the enemy's team. However, when it shatters, the particles it creates are of the original thrower's team color rather than the reflecting enemy's team color. This means RED ornaments can shatter into BLU shards and vice versa. This commit fixes that.
When a Wrap Assassin ornament shatters, it plays a shattering sound. This sound plays at a higher volume to the person who threw the ornament so they know when it breaks. When an enemy reflects an ornament, however, the sound still plays at a higher volume to the original thrower rather than the reflecting enemy, even though the information of when the ornament breaks is more useful to the reflector than the thrower. This commit makes the sound effect play louder to the reflector rather than the thrower when applicable.
…ornaments GetOwnerEntity returns the 'owner entity' of the baseball/ornament, which is the player that originally threw it. However, this is used in multiple places where we really want to know who is responsible for the ball's damage (including who may have last reflected it) which is returned by GetThrower. This change should fix reflected baseball/ornament hits and kills being attributed to their original thrower rather than their reflector like other projectiles.
Tkain
force-pushed
the
baseball-reflect-fixes
branch
from
e7d11bd to
c7c62b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In TF2, when most projectiles (barring sticky bombs) are reflected by an enemy, they change to the team of the enemy reflector, changing their appearance to that of the enemy team as a result. However, the Sandman's baseballs and the Wrap Assassin's ornaments have a few visual (and audial) discrepancies between their displayed and actual teams when reflected:
These can be observed below:
Current baseball/ornament behavior
Reflected baseball/ornament particles and sounds (note:
host_timescaleset to 0.5 for clarity):Reflecting.ornament.without.PR.mp4
Reflected baseball/ornament kill attribution:
This PR attempts to resolve these inconsistencies, ensuring that these characteristics correspond to (the team of) the enemy reflector after these projectiles are reflected. These changes can be observed below:
Baseball/ornament behavior with this PR
Reflected baseball/ornament particles and sounds (also with
host_timescaleset to 0.5):Reflecting.ornament.with.PR.mp4
Reflected baseball/ornament kill attribution:
Although they work best together, these changes are largely independent of one another, so feel free to cherry-pick them as you'd like.