just moved to lsp-zero. Finally lsp is actually working. But I lost completion at the command-prompt. By enabling my old nvim-cmp.setup(), I got it back. But does that have a cost?

[emilBeBri]

As the (reddit-style, long title lol) states, by putting this in my config I got completion of commands back:

  -- Setup nvim-cmp.
  local cmp = require'cmp'

  cmp.setup({
    mapping = cmp.mapping.preset.insert({
      ['<C-b>'] = cmp.mapping.scroll_docs(-4),
      ['<C-f>'] = cmp.mapping.scroll_docs(4),
      ['<C-Space>'] = cmp.mapping.complete(),
      ['<C-e>'] = cmp.mapping.abort(),
      ['<CR>'] = cmp.mapping.confirm({ select = true }), -- Accept currently selected item. Set `select` to `false` to only confirm explicitly selected items.
    }),
    sources = cmp.config.sources({
      { name = 'buffer' },
      { name = 'emoji' },
      { name = 'latex_symbols' },
      { name = 'nvim_lsp' },
      { name = 'nvim_lua' },
      { name = 'path' },
      { name = 'spell' },
      { name = 'tags' },
      { name = 'treesitter' },
    })
  })

  -- Set configuration for specific filetype.
  cmp.setup.filetype('gitcommit', {
    sources = cmp.config.sources({
      { name = 'git' }, -- You can specify the `cmp_git` source if you were installed it.
    }, {
      { name = 'buffer' },
    })
  })

  -- Use buffer source for `/` (if you enabled `native_menu`, this won't work anymore).
  cmp.setup.cmdline('/', {
    mapping = cmp.mapping.preset.cmdline(),
    sources = {
      { name = 'buffer' }
    }
  })

  -- Use cmdline & path source for ':' (if you enabled `native_menu`, this won't work anymore).
  cmp.setup.cmdline(':', {
    mapping = cmp.mapping.preset.cmdline(),
    sources = cmp.config.sources({
      { name = 'path' }
    }, {
      { name = 'cmdline' }
    })
  })

Could this be screwing with the lsp-zero setup in any way, though?

also, a bonus question, I was super impressed by the linter-suggestions in my R-scripts. However, the linter wants me to use double quotes as the standard in my code. I don't want to do that. Is there a way to remove that type of suggestion? I guess this is the downside of an auto-config such as lsp-zero: I actually got it working, very easily, but the options to do stuff 'under the hood' gets obscured somewhat. Or how would I come about changing this, for example?
BTW I love this plugin!

[VonHeikemen]

I think nvim-cmp will merge the old config with the new config, so the config from lsp-zero should be merge with yours. But I'm not sure.

Since you have a lot of customizations I would recommend changing the preset to lsp-compe and use .defaults.cmp_config to extend the defaults.

local lsp = require('lsp-zero')
lsp.preset('lsp-compe')

lsp.setup()

vim.opt.completeopt = {'menu', 'menuone', 'noselect'}

local cmp = require('cmp')
local cmp_config = lsp.defaults.cmp_config({
  ---
  --  Add your nvim-cmp config here
  ---
})

cmp.setup(cmp_config)

--- more code .....

also, a bonus question, I was super impressed by the linter-suggestions in my R-scripts. However, the linter wants me to use double quotes as the standard in my code. I don't want to do that. Is there a way to remove that type of suggestion?

You'll have to check the documentation for the lsp server you are using, and then modify the config for that server using the .configure function.

local lsp = require('lsp-zero')
lsp.preset('lsp-compe')

lsp.configure('name-of-the-server', {
  ---
  -- Server configuration goes here
  ---
})

lsp.setup()

The second argument in .configure is then passed to nvim-lspconfig setup function. So if you find some documentation on how to configure it with lspconfig, it should work here too.

[emilBeBri]

Ok that makes sense, thank you for taking the time to help me!

[olimorris]

For anyone coming to this, most likely after ThePrimeagen's video, my completion config is:

local lsp = require('lsp-zero')
lsp.preset('lsp-compe')

lsp.setup()

local cmp = require("cmp")
local cmp_config = lsp.defaults.cmp_config({
  formatting = {
    format = function(...) return require("lspkind").cmp_format({ mode = "symbol_text" })(...) end,
  },
  sources = {
    { name = "luasnip", priority = 100 },
    { name = "nvim_lsp", priority = 90 },
    { name = "nvim_lsp_signature_help" },
    { name = "nvim_lua", priority = 90 },
    { name = "copilot", priority = 80 },
    { name = "path", priority = 5 },
  },
})

cmp.setup(cmp_config)
cmp.setup.cmdline(":", {
  mapping = cmp.mapping.preset.cmdline(),
  sources = cmp.config.sources({
    { name = "path" },
  }, {
    {
      name = "cmdline",
      option = {
        ignore_cmds = { "Man", "!" },
      },
    },
  }),
})
cmp.setup.cmdline("/", {
  mapping = cmp.mapping.preset.cmdline(),
  sources = {
    { name = "buffer" },
  },
})