Build breaks on 32bit systems: cannot find value `SEED` in this scope

[yurivict]

error[E0425]: cannot find value `SEED` in this scope
  --> sudachi/src/util/fxhash.rs:78:25
   |
78 | impl_hash_word!(usize = SEED, u32 = SEED32, u64 = SEED64);
   |                         ^^^^ not found in this scope
   |
note: constant `crate::hash::SEED` exists but is inaccessible
  --> sudachi/src/hash.rs:20:1
   |
20 | const SEED: u64 = 0x16f11fe89b0d677cu64;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not accessible

log

FreeBSD

[mh-northlander]

It seems the SEED definition is missing for 32bit systems.

sudachi.rs/sudachi/src/util/fxhash.rs

Lines 54 to 59 in 8e08724

	const ROTATE: u32 = 5;
	const SEED64: u64 = 0x51_7c_c1_b7_27_22_0a_95;
	const SEED32: u32 = 0x9e_37_79_b9;
	#[cfg(target_pointer_width = "64")]
	const SEED: usize = SEED64 as usize;

@eiennohito
Is it safe to use this hash for 32bit systems?

[eiennohito]

The hash function itself should work, but for 32-bit compatibility all usize usages should be checked.

The other painful thing is memory mapping of dictionaries which will be a problem in a 32-bit environment as the dictionary is pretty large and mmap can fail simply because of lack of the address space (there is only 2GB available for userspace). Also testing for 32-bit architectures can have its own cans of worms as CI mostly contain only 64 bit OS without 32-bit libraries and 32-bit userspace on 64-bit system does not have that much virtual memory pressure problem as native 32-bit environment has.