tests for confirmation timeout

Author: kitttang

e2e/cypress/e2e/runner/confirmationTimeout.feature

@@ -0,0 +1,13 @@
+
+Feature: Confirmation timeout 
+
+  Background: Given the form "confirmation-timeout" exists
+
+  Scenario: 
+   And I navigate to the confirmation-timeout form
+   Then I continue
+   Then I continue
+   Then I see "Application Complete"
+   And I wait "10000" milliseconds
+   And I navigate to "confirmation-timeout/status"
+   Then I don't see "Application complete"

e2e/cypress/e2e/runner/confirmationTimeout.js

@@ -0,0 +1,6 @@
+import { When } from "@badeball/cypress-cucumber-preprocessor";
+
+When("I upload the file {string}", (filename) => {
+  cy.get("input[type=file]").attachFile(filename);
+  cy.findByRole("button", { name: /continue/i }).click();
+});

e2e/cypress/fixtures/confirmation-timeout.json

@@ -0,0 +1,29 @@
+{
+  "metadata": {},
+  "startPage": "/confirmation-timeout",
+  "confirmationTimeout": 10,
+  "pages": [
+    {
+      "title": "Confirmation Timeout",
+      "path": "/confirmation-timeout",
+      "components": [
+      ],
+      "next": [{ "path": "/summary" }]
+    },
+    {
+      "title": "Summary",
+      "path": "/summary",
+      "controller": "./pages/summary.js",
+      "components": [],
+      "next": []
+    }
+  ],
+  "lists": [],
+  "sections": [],
+  "conditions": [],
+  "fees": [],
+  "outputs": [],
+  "version": 2,
+  "skipSummary": false,
+  "feeOptions": {}
+}

e2e/cypress/support/step_definitions/common/i_wait.js

@@ -0,0 +1,5 @@
+import { When } from "@badeball/cypress-cucumber-preprocessor";
+
+When("I wait {int}", (milliseconds) => {
+  cy.wait(milliseconds);
+});

model/src/data-model/types.ts

@@ -194,4 +194,5 @@ export type FormDefinition = {
   paymentReferenceFormat?: string;
   feeOptions: FeeOptions;
   exitOptions: ExitOptions;
+  confirmationSessionTimeout: number | undefined;
 };

model/src/schema/schema.ts

@@ -328,6 +328,7 @@ export const Schema = joi
     feeOptions: feeOptionSchema,
     exitOptions: exitSchema.optional(),
     showFilenamesOnSummaryPage: joi.boolean().optional(),
+    confirmationSessionTimeout: joi.number().optional()
   });
 
 /**

runner/src/server/plugins/applicationStatus/index.ts

@@ -3,6 +3,7 @@ import { HapiRequest, HapiResponseToolkit } from "../../types";
 import { retryPay } from "./retryPay";
 import { handleUserWithConfirmationViewModel } from "./handleUserWithConfirmationViewModel";
 import { checkUserCompletedSummary } from "./checkUserCompletedSummary";
+import config from "../../config";
 
 import Joi from "joi";
 import {
@@ -71,9 +72,10 @@ const index = {
               newReference
             );
 
-            await cacheService.setConfirmationState(request, {
-              confirmation: viewModel,
-            });
+            const confirmationTimeout = form.def.confirmationTimeout ?? config.confirmationSessionTimeout;    
+            
+            await cacheService.setConfirmationState(request, { confirmation: viewModel }, confirmationTimeout);
+            
             await cacheService.clearState(request);
 
             return h.view("confirmation", viewModel);

runner/src/server/services/cacheService.ts

@@ -73,9 +73,10 @@ export class CacheService {
     return await this.cache.get(key);
   }
 
-  async setConfirmationState(request: HapiRequest, viewModel) {
+  async setConfirmationState(request: HapiRequest, viewModel, ttl?: number) {
     const key = this.Key(request, ADDITIONAL_IDENTIFIER.Confirmation);
-    return this.cache.set(key, viewModel, confirmationSessionTimeout);
+    const timeout = ttl ?? confirmationSessionTimeout;
+    return this.cache.set(key, viewModel, timeout);
   }
 
   async createSession(