Skip to content

Commit e1bbd22

Browse files
committed
cleanup: Tidy boilerplate ToDos
1 parent 53eb9d5 commit e1bbd22

File tree

2 files changed

+14
-27
lines changed

2 files changed

+14
-27
lines changed

config/manager/manager.yaml

Lines changed: 13 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -38,26 +38,19 @@ spec:
3838
labels:
3939
control-plane: controller-manager
4040
spec:
41-
# TODO(user): Uncomment the following code to configure the nodeAffinity expression
42-
# according to the platforms which are supported by your solution.
43-
# It is considered best practice to support multiple architectures. You can
44-
# build your manager image using the makefile target docker-buildx.
45-
# affinity:
46-
# nodeAffinity:
47-
# requiredDuringSchedulingIgnoredDuringExecution:
48-
# nodeSelectorTerms:
49-
# - matchExpressions:
50-
# - key: kubernetes.io/arch
51-
# operator: In
52-
# values:
53-
# - amd64
54-
# - arm64
55-
# - ppc64le
56-
# - s390x
57-
# - key: kubernetes.io/os
58-
# operator: In
59-
# values:
60-
# - linux
41+
affinity:
42+
nodeAffinity:
43+
requiredDuringSchedulingIgnoredDuringExecution:
44+
nodeSelectorTerms:
45+
- matchExpressions:
46+
- key: kubernetes.io/arch
47+
operator: In
48+
values:
49+
- amd64
50+
- key: kubernetes.io/os
51+
operator: In
52+
values:
53+
- linux
6154
securityContext:
6255
runAsNonRoot: true
6356
# TODO(user): For common cases that do not require escalating privileges
@@ -94,8 +87,6 @@ spec:
9487
port: 8081
9588
initialDelaySeconds: 5
9689
periodSeconds: 10
97-
# TODO(user): Configure the resources accordingly based on the project requirements.
98-
# More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
9990
resources:
10091
limits:
10192
cpu: 500m

controllers/onload_controller.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,6 @@ type OnloadReconciler struct {
5353

5454
// Reconcile is part of the main kubernetes reconciliation loop which aims to
5555
// move the current state of the cluster closer to the desired state.
56-
// TODO(user): Modify the Reconcile function to compare the state specified by
57-
// the Onload object against the actual cluster state, and then
58-
// perform operations to make the cluster state reflect the state specified by
59-
// the user.
6056
//
6157
// For more details, check Reconcile and its Result here:
6258
// - https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.14.1/pkg/reconcile
@@ -1190,7 +1186,7 @@ func (r *OnloadReconciler) nodeLabelWatchFunc(ctx context.Context, obj client.Ob
11901186
return requests
11911187
}
11921188

1193-
// TODO: Check labels here to only requeue relevant onloads.
1189+
// TODO(ON-15506): Check labels here to only requeue relevant onloads.
11941190

11951191
for _, onload := range onloadList.Items {
11961192
request := reconcile.Request{NamespacedName: types.NamespacedName{Name: onload.Name, Namespace: onload.Namespace}}

0 commit comments

Comments
 (0)