Refactor

Author: Xvezda

src/rules/no-implicit-propagation.js

@@ -3,6 +3,7 @@ const { ESLintUtils, AST_NODE_TYPES } = require('@typescript-eslint/utils');
 const utils = require('@typescript-eslint/type-utils');
 const {
   getLast,
+  getNodeID,
   createRule,
   isInHandledContext,
   typesToUnionString,
@@ -147,8 +148,8 @@ module.exports = createRule({
 
     /** @param {import('@typescript-eslint/utils').TSESTree.Expression} node */
     const visitExpression = (node) => {
-      if (visitedNodes.has(node.range[0])) return;
-      visitedNodes.add(node.range[0]);
+      if (visitedNodes.has(getNodeID(node))) return;
+      visitedNodes.add(getNodeID(node));
 
       if (isInHandledContext(node)) return;
 

src/rules/no-undocumented-throws.js

@@ -5,6 +5,7 @@ const ts = require('typescript');
 const {
   getFirst,
   getLast,
+  getNodeID,
   createRule,
   findParent,
   hasJSDocThrowsTag,
@@ -60,14 +61,6 @@ module.exports = createRule({
 
     const visitedNodes = new Set();
 
-    /**
-     * @param {import('@typescript-eslint/utils').TSESTree.Node} node
-     * @returns {string}
-     */
-    const getNodeID = (node) => {
-      return `${node.type}:${node.loc.start.line}:${node.loc.start.column}`;
-    };
-
     /**
      * Group throw statements in functions
      * @type {Map<string, import('@typescript-eslint/utils').TSESTree.ThrowStatement[]>}

src/utils.js

@@ -52,6 +52,14 @@ const hasThrowsTag = comment =>
   comment.includes('@throws') ||
   comment.includes('@exception');
 
+/**
+ * @param {import('@typescript-eslint/utils').TSESTree.Node} node
+ * @returns {string}
+ */
+const getNodeID = (node) => {
+  return `${node.loc.start.line}:${node.loc.start.column}`;
+};
+
 /**
  * Check if node has JSDoc comment with @throws or @exception tag.
  *
@@ -410,6 +418,7 @@ const createInsertJSDocBeforeFixer = (sourceCode, node, typeString) => {
 module.exports = {
   getFirst,
   getLast,
+  getNodeID,
   createRule,
   hasThrowsTag,
   hasJSDocThrowsTag,