For PR thephpleague#36 - validate card number only if card not present.

Author: judgej

src/AIMGateway.php

@@ -14,6 +14,20 @@
  */
 class AIMGateway extends AbstractGateway
 {
+    /**
+     * The device type collecting credit card data.
+     */
+    const DEVICE_TYPE_UNKNOWN = 1;
+    const DEVICE_TYPE_UNATTENDED_TERMINAL = 2;
+    const DEVICE_TYPE_SELF_SERVICE_TERMINAL = 3;
+    const DEVICE_TYPE_ELECTRONIC_CASH_REGISTER = 4;
+    const DEVICE_TYPE_PC_TERMINAL = 5;
+    const DEVICE_TYPE_AIRPAY = 6;
+    const DEVICE_TYPE_WIRELESS_POS = 7;
+    const DEVICE_TYPE_WEBSITE = 8;
+    const DEVICE_TYPE_DIAL_TERMINAL = 9;
+    const DEVICE_TYPE_VIRTUAL_TERMINAL = 10;
+
     public function getName()
     {
         return 'Authorize.Net AIM';
@@ -29,7 +43,7 @@ public function getDefaultParameters()
             'hashSecret'        => '',
             'liveEndpoint'      => 'https://api2.authorize.net/xml/v1/request.api',
             'developerEndpoint' => 'https://apitest.authorize.net/xml/v1/request.api',
-            'deviceType'        => 1 // Device used to make the transaction. Required for card present. "1" = Unknown.
+            'deviceType'        => static::DEVICE_TYPE_UNKNOWN
         );
     }
 
@@ -115,8 +129,8 @@ public function getDeviceType()
     }
 
     /**
-     * Sets the type of device used to collect the credit card data. A device type is required for card present
-     * transactions.
+     * Sets the type of device used to collect the credit card data.
+     * A device type is required for card present transactions.
      *
      * 1 = Unknown
      * 2 = Unattended Terminal

src/Message/AIMAuthorizeRequest.php

@@ -37,10 +37,12 @@ protected function addPayment(\SimpleXMLElement $data)
             return;
         }
 
+        // The CreditCard object must be present.
         $this->validate('card');
+
         /** @var CreditCard $card */
         $card = $this->getCard();
-        $card->validate();
+
         if ($card->getTracks()) {
             // Card present
             if ($track1 = $card->getTrack1()) {
@@ -49,7 +51,11 @@ protected function addPayment(\SimpleXMLElement $data)
                 $data->transactionRequest->payment->trackData->track2 = $track2;
             }
         } else {
-            // Card not present
+            // Card not present.
+
+            // Validate sufficient card details have been supplied.
+            $card->validate();
+
             $data->transactionRequest->payment->creditCard->cardNumber = $card->getNumber();
             $data->transactionRequest->payment->creditCard->expirationDate = $card->getExpiryDate('my');
             $data->transactionRequest->payment->creditCard->cardCode = $card->getCvv();

tests/Message/AIMAuthorizeRequestTest.php

@@ -96,6 +96,13 @@ public function testGetDataCardPresentTrack1()
     {
         $card = $this->getValidCard();
         $card['tracks'] = '%B4242424242424242^SMITH/JOHN ^2511126100000000000000444000000?;4242424242424242=25111269999944401?';
+
+        // If sending tracks, then the card number and expiry date are not required.
+        unset($card['number']);
+        unset($card['expiryMonth']);
+        unset($card['expiryYear']);
+        unset($card['cvv']);
+
         $this->request->initialize(array(
             'amount' => '12.12',
             'card' => $card,