Merge pull request #9 from aimeoscom/master

judgej · web-flow · commit 0f4a8a224f23 · 2020-06-12T13:51:28.000+01:00
Fixes isSuccessful() which returned true in almost all cases
diff --git a/src/Messages/NotificationValuesTrait.php b/src/Messages/NotificationValuesTrait.php
@@ -168,8 +168,8 @@ public function getApprovalCode()
      */
     public function isSuccessful()
     {
-        return $this->getTransactionState() === static::TRANSACTION_STATE_BILLED
-            || $this->getOperationStatus() === static::OPERATION_STATUS_OK;
+        return $this->getOperation() === 'CONFIRMATION' && $this->getTransactionState() === static::TRANSACTION_STATE_BILLED
+            || $this->getReturnCode() === 'PROFILE_USED' && $this->getOperationStatus() === static::OPERATION_STATUS_OK;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -168,8 +168,8 @@ public function getApprovalCode()`
`168`	`168`	`*/`
`169`	`169`	`public function isSuccessful()`
`170`	`170`	`{`
`171`		`- return $this->getTransactionState() === static::TRANSACTION_STATE_BILLED`
`172`		`- \|\| $this->getOperationStatus() === static::OPERATION_STATUS_OK;`
	`171`	`+ return $this->getOperation() === 'CONFIRMATION' && $this->getTransactionState() === static::TRANSACTION_STATE_BILLED`
	`172`	`+ \|\| $this->getReturnCode() === 'PROFILE_USED' && $this->getOperationStatus() === static::OPERATION_STATUS_OK;`
`173`	`173`	`}`
`174`	`174`
`175`	`175`	`/**`