fix: testing bugs in NumberField, Tooltip, and Popover (#9342)

* fix tooltip positioning

* fix popover tip separation

* fix numberfield infinite spin on mobile

* make math more clear

Author: snowystinger

packages/@react-aria/spinbutton/src/useSpinButton.ts

@@ -256,9 +256,8 @@ export function useSpinButton(
           if (!isSpinning.current && isUp.current) {
             onIncrement?.();
           }
-        } else {
-          clearAsync();
         }
+        clearAsync();
         isUp.current = false;
         setIsIncrementPressed(null);
       },
@@ -296,9 +295,8 @@ export function useSpinButton(
           if (!isSpinning.current && isUp.current) {
             onDecrement?.();
           }
-        } else {
-          clearAsync();
         }
+        clearAsync();
         isUp.current = false;
         setIsDecrementPressed(null);
       },

packages/@react-spectrum/s2/src/Popover.tsx

@@ -156,8 +156,8 @@ let arrow = style({
   },
   translateX: {
     placement: {
-      left: -4,
-      right: 4
+      left: '-25%',
+      right: '25%'
     }
   },
   strokeWidth: 1,

packages/@react-spectrum/s2/src/Tooltip.tsx

@@ -68,7 +68,6 @@ const tooltip = style<TooltipRenderProps & {colorScheme: ColorScheme | 'light da
   borderRadius: 'default',
   paddingX: 'edge-to-text',
   paddingY: centerPadding(),
-  margin: 8,
   transition: 'default',
   transitionDuration: 200,
   transitionTimingFunction: {
@@ -165,7 +164,7 @@ export const Tooltip = forwardRef(function Tooltip(props: TooltipProps, ref: DOM
       arrowBoundaryOffset={borderRadius}
       containerPadding={containerPadding}
       crossOffset={crossOffset}
-      offset={4}
+      offset={4 + 5} // 4px offset + 5px arrow height
       placement={placement}
       shouldFlip={shouldFlip}
       ref={tooltipRef}