Revert "fix(overlay): modal and page overlay should not allow body scroll (#5710)"

This reverts commit ee1bae6.

Author: Helen Le

packages/overlay/src/OverlayStack.ts

@@ -27,10 +27,6 @@ class OverlayStack {
 
     stack: Overlay[] = [];
 
-    private originalBodyOverflow = '';
-
-    private bodyScrollBlocked = false;
-
     constructor() {
         this.bindEvents();
     }
@@ -83,25 +79,6 @@ class OverlayStack {
             this.stack.splice(overlayIndex, 1);
         }
         overlay.open = false;
-
-        this.manageBodyScroll();
-    }
-
-    /**
-     * Manage body scroll blocking based on modal/page overlays
-     */
-    private manageBodyScroll(): void {
-        const shouldBlock = this.stack.some(
-            (overlay) => overlay.type === 'modal' || overlay.type === 'page'
-        );
-        if (shouldBlock && !this.bodyScrollBlocked) {
-            this.originalBodyOverflow = document.body.style.overflow || '';
-            document.body.style.overflow = 'hidden';
-            this.bodyScrollBlocked = true;
-        } else if (!shouldBlock && this.bodyScrollBlocked) {
-            document.body.style.overflow = this.originalBodyOverflow;
-            this.bodyScrollBlocked = false;
-        }
     }
 
     /**
@@ -271,7 +248,6 @@ class OverlayStack {
             overlay.addEventListener('beforetoggle', this.handleBeforetoggle, {
                 once: true,
             });
-            this.manageBodyScroll();
         });
     }
 

packages/overlay/test/index.ts

@@ -650,85 +650,6 @@ export const runOverlayTriggerTests = (type: string): void => {
                     'hover content is not available at point'
                 ).to.be.false;
             });
-
-            it('blocks body scroll when modal overlay is opened and restores when closed', async function () {
-                const originalBodyOverflow = document.body.style.overflow;
-
-                const modalTrigger = this.outerTrigger;
-                modalTrigger.type = 'modal';
-                await elementUpdated(modalTrigger);
-
-                // Open modal overlay
-                const opened = oneEvent(modalTrigger, 'sp-opened');
-                this.outerButton.click();
-                await opened;
-
-                // Check that body scroll is blocked
-                expect(document.body.style.overflow).to.equal('hidden');
-
-                // Close modal overlay
-                const closed = oneEvent(modalTrigger, 'sp-closed');
-                sendMouse({
-                    steps: [
-                        {
-                            type: 'click',
-                            position: [1, 1],
-                        },
-                    ],
-                });
-                await closed;
-
-                // Check that body scroll is restored
-                expect(document.body.style.overflow).to.equal(
-                    originalBodyOverflow
-                );
-            });
-
-            it('actually prevents page scrolling when modal overlay is open and restores scrolling when closed', async function () {
-                // Create a long enough page to enable scrolling
-                const longContent = document.createElement('div');
-                longContent.style.height = '200vh'; // Make page twice viewport height
-                longContent.style.width = '100%';
-                longContent.style.backgroundColor = 'transparent';
-                document.body.appendChild(longContent);
-
-                const modalTrigger = this.outerTrigger;
-                modalTrigger.type = 'modal';
-                await elementUpdated(modalTrigger);
-
-                // Open modal overlay
-                const opened = oneEvent(modalTrigger, 'sp-opened');
-                this.outerButton.click();
-                await opened;
-
-                // Attempt to scroll while modal is open
-                const scrollYBeforeScroll = window.scrollY;
-                window.scrollTo(0, 100);
-                await nextFrame();
-
-                // Verify that scrolling was prevented
-                expect(window.scrollY).to.equal(scrollYBeforeScroll);
-
-                // Close modal overlay
-                const closed = oneEvent(modalTrigger, 'sp-closed');
-                await sendMouse({
-                    steps: [
-                        {
-                            type: 'click',
-                            position: [1, 1],
-                        },
-                    ],
-                });
-                await closed;
-
-                // Verify scrolling works again after modal is closed
-                window.scrollTo(0, 100);
-                await nextFrame();
-                expect(window.scrollY).to.equal(100);
-
-                // Clean up
-                document.body.removeChild(longContent);
-            });
         });
         describe('System interactions', () => {
             afterEach(async () => {