Skip to content

Commit 1c8d9c0

Browse files
committed
chore: update overlay directive story
1 parent a500622 commit 1c8d9c0

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.changeset/eight-coats-read.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
'@spectrum-web-components/overlay': patch
33
---
44

5-
Sets this.listenerHost = this.target in overlay-trigger-directive’s overridden update() when a listenerHost is not already defined. This prevents type errors during the reconnected flow when listenerHost is required but unset.
5+
Guards `OverlayTriggerDirective`'s `reconnected()` implementation so it only calls `init()` after an overlay instance exists. This prevents type errors during the reconnected flow when `listenerHost` would otherwise be unset because the overlay is not yet ready.

1st-gen/packages/overlay/stories/overlay-directive.stories.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ import './overlay-story-components.js';
5353
import { tooltip } from '@spectrum-web-components/tooltip/src/tooltip-directive.js';
5454
import { ifDefined } from '@spectrum-web-components/base/src/directives.js';
5555
import { state } from '@spectrum-web-components/base/src/decorators.js';
56+
import { cache } from 'lit/directives/cache.js';
5657

5758
const storyStyles = html`
5859
<style>
@@ -314,7 +315,7 @@ class ManagedOverlayTrigger extends LitElement {
314315
Create Overlay Render Button And Open Overlay
315316
</sp-button>
316317
317-
${this.isRenderOverlay ? this.renderOverlayButton() : html``}
318+
${cache(this.isRenderOverlay ? this.renderOverlayButton() : html``)}
318319
`;
319320
}
320321

0 commit comments

Comments
 (0)