Skip to content

$dirty tracking broken when attribute is a Set #1131

@p3drosola

Description

@p3drosola

Package version

21.7.0

Describe the bug

Lucid uses 'fast-deep-equal' for comparing values to track changes

As per the package documentation: https://github.com/epoberezkin/fast-deep-equal

To support ES6 Maps, Sets and Typed arrays equality use:
var equal = require('fast-deep-equal/es6');

Lucid does not use the es6 version, so comparing Sets always considers them equal, and as such will not save the changes.

Opening a PR briefly with a suggested fix.

Reproduction repo

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions