From 4a9f79a4843c3cee27f55df6486a75cba9caf4b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oscar=20S=C3=B6derlund?= Date: Wed, 19 Nov 2025 14:12:25 +0100 Subject: [PATCH] feat(131): allow show_deleted on Get Should be allowed when the API uses soft deletes as specified in https://aep.dev/164/ --- rules/aep0131/request_unknown_fields.go | 9 +++++---- rules/aep0131/request_unknown_fields_test.go | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/rules/aep0131/request_unknown_fields.go b/rules/aep0131/request_unknown_fields.go index 0e8a8b3c..ab30292f 100644 --- a/rules/aep0131/request_unknown_fields.go +++ b/rules/aep0131/request_unknown_fields.go @@ -25,10 +25,11 @@ import ( ) var allowedFields = stringset.New( - "path", // AEP-131 - "request_id", // AEP-155 - "read_mask", // AEP-157 - "view", // AEP-157 + "path", // AEP-131 + "request_id", // AEP-155 + "read_mask", // AEP-157 + "view", // AEP-157 + "show_deleted", // AEP-164 ) // Get methods should not have unrecognized fields. diff --git a/rules/aep0131/request_unknown_fields_test.go b/rules/aep0131/request_unknown_fields_test.go index 7ba28354..c2c7fa1c 100644 --- a/rules/aep0131/request_unknown_fields_test.go +++ b/rules/aep0131/request_unknown_fields_test.go @@ -44,6 +44,7 @@ func TestUnknownFields(t *testing.T) { {"Invalid", "GetBookRequest", "application_id", builder.FieldTypeString(), testutils.Problems{{ Message: "Unexpected field", }}}, + {"ShowDeleted", "GetBookRequest", "show_deleted", builder.FieldTypeBool(), testutils.Problems{}}, {"Irrelevant", "AcquireBookRequest", "application_id", builder.FieldTypeString(), testutils.Problems{}}, }