Merge pull request #58 from max-mi/master

Fix PHP Warnings/Notices

Author: joseconsador

src/app/code/community/Zendesk/Zendesk/Block/Adminhtml/Create/Customer.php

@@ -29,7 +29,7 @@ public function getHeaderText()
         return Mage::helper('zendesk')->__('Please Select User to Add');
     }
 
-    public function getButtonsHtml()
+    public function getButtonsHtml($area = null)
     {
         $addButtonData = array(
             'label' => Mage::helper('zendesk')->__('Select User'),

src/app/code/community/Zendesk/Zendesk/Block/Adminhtml/Create/Order.php

@@ -29,7 +29,7 @@ public function getHeaderText()
         return Mage::helper('zendesk')->__('Please Select Order to Add');
     }
 
-    public function getButtonsHtml()
+    public function getButtonsHtml($area = null)
     {
         $addButtonData = array(
             'label' => Mage::helper('zendesk')->__('Select Order'),

src/app/code/community/Zendesk/Zendesk/Block/Adminhtml/Dashboard/Tab/Tickets/Grid/Renderer/Email.php

@@ -19,7 +19,7 @@
 class Zendesk_Zendesk_Block_Adminhtml_Dashboard_Tab_Tickets_Grid_Renderer_Email extends Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Abstract {
 
     public function render(Varien_Object $row) {
-        $users = Mage::registry('zendesk_users');
+        $users = Mage::registry('zendesk_users') ? Mage::registry('zendesk_users') : array();
         $value = (int) $row->getData($this->getColumn()->getIndex());
 
         $found = array_filter($users, function($user) use($value) {

src/app/code/community/Zendesk/Zendesk/Block/Adminhtml/Dashboard/Tab/Tickets/Grid/Renderer/User.php

@@ -19,7 +19,7 @@
 class Zendesk_Zendesk_Block_Adminhtml_Dashboard_Tab_Tickets_Grid_Renderer_User extends Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Abstract {
 
     public function render(Varien_Object $row) {
-        $users = Mage::registry('zendesk_users');
+        $users = Mage::registry('zendesk_users') ? Mage::registry('zendesk_users') : array();
         $value = (int) $row->getData($this->getColumn()->getIndex());
 
         $found = array_filter($users, function($user) use($value) {

src/app/code/community/Zendesk/Zendesk/Model/Api/Requesters.php

@@ -17,7 +17,7 @@
 
 class Zendesk_Zendesk_Model_Api_Requesters extends Zendesk_Zendesk_Model_Api_Users
 {
-    public function create($email, $name)
+    public function create($email, $name = null)
     {
         if(!Zend_Validate::is($email, 'EmailAddress')) {
             throw new InvalidArgumentException('Invalid email address provided');

src/app/code/community/Zendesk/Zendesk/Model/Resource/Tickets/Collection.php

@@ -132,9 +132,7 @@ public function getCollection(array $params = array()) {
 
     public function getCollectionFromView($viewId, array $params = array()) {
         $view = Mage::getModel('zendesk/api_views')->execute($viewId, $params);
-        
-        // Loop through the rows if the view is found and active
-        if (!empty($view)) {
+        if (is_array($view['rows'])) {
             foreach ($view['rows'] as $row) {
                 $ticket = array_merge($row, $row['ticket']);
 
@@ -144,10 +142,9 @@ public function getCollectionFromView($viewId, array $params = array()) {
                 $obj->setData($ticket);
                 $this->addItem($obj);
             }
-
-            $this->_viewColumns = $view['columns'];
         }
 
+        $this->_viewColumns = $view['columns'] ? $view['columns'] : array();
 
         $this->setPageSize($params['per_page']);
         $this->setCurPage($params['page']);