refact convet query to filter helper

Author: ahmedglez

src/helpers/convertQueryToFilter.js

@@ -1,45 +1,36 @@
-/* thank you chatgpt */
 const { userTypes } = require('@src/constants/userTypes')
 
+const attributeFilters = {
+  uid: (value) => `uid=${value}`,
+  cn: (value) => `cn=${value}`,
+  username: (value) => `uid=${value}`,
+  ci: (value) => `ci=${value}`,
+  email: (value) => `maildrop=${value}`,
+}
+
 const userTypeFilters = {
   student: userTypes[0],
-  employee: userTypes[1],
-  docent_employee: userTypes[2],
+  docent_employee: userTypes[1],
+  employee: userTypes[2],
 }
 
 const createLdapFilterFromQuery = (query) => {
   const filters = []
 
-  if (query && Object.keys(query).length === 2) {
-    return ''
-  }
-
-  if (query.uid) {
-    filters.push(`(uid=${query.uid})`)
-  }
-
-  if (query.cn) {
-    filters.push(`(cn=${query.cn})`)
+  for (const key in query) {
+    if (attributeFilters[key] && query[key]) {
+      filters.push(`(${attributeFilters[key](query[key])})`)
+    } else if (key === 'userType' && userTypeFilters[query[key]]) {
+      filters.push(`(userType=${userTypeFilters[query[key]]})`)
+    }
   }
 
-  if (query.username) {
-    filters.push(`(uid=${query.username})`)
-  }
-
-  if (query.ci) {
-    filters.push(`(ci=${query.ci})`)
-  }
-
-  if (query.email) {
-    filters.push(`(maildrop=${query.email})`)
-  }
-
-  if (query.userType && userTypeFilters[query.userType]) {
-    filters.push(`(userType=${userTypeFilters[query.userType]})`)
+  if (filters.length === 0) {
+    return ''
   }
 
   // Combine multiple filters using logical AND
-  const ldapFilter = `${filters.join('')}`
+  const ldapFilter = filters.join('')
 
   return ldapFilter
 }