Improve code

Author: akalongman

src/Lodash/Http/Resources/JsonResource.php

@@ -95,6 +95,11 @@ public function appendAdditional(array $data): self
         return $this;
     }
 
+    public function jsonOptions(): int
+    {
+        return JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE;
+    }
+
     protected function getResourceData(): array
     {
         if ($this->resource instanceof TransformableContract) {
@@ -188,9 +193,4 @@ private static function undot(array $array): array
 
         return $result;
     }
-
-    public function jsonOptions(): int
-    {
-        return JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE;
-    }
 }

src/Lodash/Http/Resources/JsonResourceCollection.php

@@ -42,6 +42,11 @@ public function appendAdditional(array $data): self
         return $this;
     }
 
+    public function jsonOptions(): int
+    {
+        return JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE;
+    }
+
     protected function preparePaginatedResponse($request)
     {
         if ($this->preserveAllQueryParameters) {
@@ -52,9 +57,4 @@ protected function preparePaginatedResponse($request)
 
         return (new PaginatedResourceResponse($this))->toResponse($request);
     }
-
-    public function jsonOptions(): int
-    {
-        return JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE;
-    }
 }

src/Lodash/ServiceProvider.php

@@ -138,7 +138,7 @@ protected function loadValidations(): void
         }
 
         Validator::extend('type', function ($attribute, $value, $parameters, $validator): bool {
-            $validator->addReplacer('type', function ($message, $attribute, $rule, $parameters): string {
+            $validator->addReplacer('type', static function ($message, $attribute, $rule, $parameters): string {
                 return str_replace(':type', $parameters[0], $message);
             });
 

src/Lodash/Validation/StrictTypesValidator.php

@@ -4,6 +4,9 @@
 
 namespace Longman\LaravelLodash\Validation;
 
+use function gettype;
+use function in_array;
+
 readonly class StrictTypesValidator
 {
     protected const NATIVE_TYPE_INT = 'integer';

tests/Bootstrap.php

@@ -12,13 +12,13 @@
  */
 date_default_timezone_set('UTC');
 
-$root = realpath(dirname(dirname(__FILE__)));
+$root = realpath(__DIR__);
 /**
  * Check that --dev composer installation was done
  */
 if (! file_exists($root . '/vendor/autoload.php')) {
     throw new Exception(
-        'Please run "php composer.phar install --dev" in root directory 
+        'Please run "php composer.phar install --dev" in root directory
         to setup unit test dependencies before running the tests',
     );
 }

tests/Unit/TestCase.php

@@ -7,14 +7,14 @@
 use Longman\LaravelLodash\Cache\CacheServiceProvider;
 use Longman\LaravelLodash\Debug\DebugServiceProvider;
 use Longman\LaravelLodash\Elasticsearch\ElasticsearchServiceProvider;
-use Longman\LaravelLodash\ServiceProvider;
 use Longman\LaravelLodash\Queue\QueueServiceProvider;
 use Longman\LaravelLodash\Redis\RedisServiceProvider;
+use Longman\LaravelLodash\ServiceProvider;
 use Orchestra\Testbench\TestCase as BaseTestCase;
 
 class TestCase extends BaseTestCase
 {
-    protected function getPackageProviders($app)
+    protected function getPackageProviders($app): array
     {
         return [
             ServiceProvider::class,