feat(node): merge PR elide-dev#1618 content; resolve stream/promises conflicts favoring completed finished/pipeline semantics

Author: akapug

packages/graalvm/src/main/kotlin/elide/runtime/node/stream/NodeStreamPromises.kt

@@ -12,6 +12,7 @@
  */
 package elide.runtime.node.stream
 
+import org.graalvm.polyglot.Value
 import org.graalvm.polyglot.proxy.ProxyExecutable
 import elide.annotations.Factory
 import elide.annotations.Singleton
@@ -26,7 +27,8 @@ import elide.runtime.intrinsics.js.JsPromise
 import elide.runtime.intrinsics.js.node.StreamPromisesAPI
 import elide.runtime.lang.javascript.NodeModuleName
 import elide.runtime.lang.javascript.asJsSymbolString
-import org.graalvm.polyglot.Value
+import elide.runtime.intrinsics.js.CompletableJsPromise
+import elide.runtime.intrinsics.js.JsPromise as JsPromiseFactory
 
 // Internal symbol where the Node built-in module is installed.
 private val STREAM_PROMISES_MODULE_SYMBOL = "node_${NodeModuleName.STREAM_PROMISES.asJsSymbolString()}"
@@ -57,11 +59,162 @@ private val ALL_PROMISES_PROPS = arrayOf(
  */
 internal class NodeStreamPromises : ReadOnlyProxyObject, StreamPromisesAPI {
   //
+  private fun valueBooleanOrNull(obj: Value, name: String): Boolean? {
+    return try {
+      if (obj.hasMembers() && obj.hasMember(name)) {
+        val v = obj.getMember(name)
+        if (v.isBoolean) v.asBoolean() else null
+      } else null
+    } catch (_: Throwable) { null }
+  }
+
+  private fun valueOrNull(obj: Value, name: String): Value? {
+    return try {
+      if (obj.hasMembers() && obj.hasMember(name)) obj.getMember(name) else null
+    } catch (_: Throwable) { null }
+  }
+
+  private fun finished(stream: Value): CompletableJsPromise<Unit> {
+    val promise: CompletableJsPromise<Unit> = JsPromiseFactory()
+
+    // If already errored, reject immediately.
+    valueOrNull(stream, "errored")?.let { err ->
+      if (!err.isNull) {
+        promise.reject(err)
+        return promise
+      }
+    }
+
+    // If already ended/finished, resolve immediately.
+    val readableEnded = valueBooleanOrNull(stream, "readableEnded") == true
+    val writableFinished = valueBooleanOrNull(stream, "writableFinished") == true
+    if (readableEnded || writableFinished) {
+      promise.resolve(Unit)
+      return promise
+    }
+
+    // Attach listeners.
+    val listeners = mutableListOf<Pair<String, Value>>()
+    fun addOnce(event: String, listener: ProxyExecutable) {
+      val v = Value.asValue(listener)
+      listeners += event to v
+      stream.invokeMember("once", event, v)
+    }
+    fun cleanup() {
+      if (stream.canInvokeMember("off")) {
+        listeners.forEach { (event, l) ->
+          try {
+            stream.invokeMember("off", event, l)
+          } catch (_: Throwable) { /* ignore */ }
+        }
+      }
+      listeners.clear()
+    }
+
+    addOnce(StreamEventName.END, ProxyExecutable {
+      cleanup()
+      promise.resolve(Unit)
+    })
+    addOnce(StreamEventName.FINISH, ProxyExecutable {
+      cleanup()
+      promise.resolve(Unit)
+    })
+    addOnce(StreamEventName.ERROR, ProxyExecutable { args ->
+      cleanup()
+      promise.reject(args.getOrNull(0))
+    })
+
+    return promise
+  }
+
+  private fun pipeline(vararg streams: Value): CompletableJsPromise<Unit> {
+    val promise: CompletableJsPromise<Unit> = JsPromiseFactory()
+
+    if (streams.isEmpty()) {
+      // Resolve immediately for empty pipeline.
+      promise.resolve(Unit)
+      return promise
+    }
+
+    // Connect streams via .pipe()
+    try {
+      for (i in 0 until streams.size - 1) {
+        val src = streams[i]
+        val dest = streams[i + 1]
+        if (src.canInvokeMember("pipe")) {
+          src.invokeMember("pipe", dest)
+        }
+      }
+    } catch (t: Throwable) {
+      promise.reject(t)
+      return promise
+    }
+
+    // Cleanup helpers
+    val listenerMap = HashMap<Value, MutableList<Pair<String, Value>>>(streams.size)
+    fun addOnce(target: Value, event: String, listener: ProxyExecutable) {
+      val v = Value.asValue(listener)
+      listenerMap.getOrPut(target) { mutableListOf() }.add(event to v)
+      target.invokeMember("once", event, v)
+    }
+    fun cleanupAll() {
+      streams.forEach { s ->
+        if (s.canInvokeMember("off")) {
+          listenerMap[s]?.forEach { (event, l) ->
+            try {
+              s.invokeMember("off", event, l)
+            } catch (_: Throwable) { /* ignore */ }
+          }
+        }
+      }
+      listenerMap.clear()
+    }
+
+    // Reject on first error from any stream.
+    streams.forEach { s ->
+      if (s.canInvokeMember("once")) {
+        addOnce(s, StreamEventName.ERROR, ProxyExecutable { args ->
+          cleanupAll()
+          promise.reject(args.getOrNull(0))
+        })
+      }
+    }
+
+    // Resolve when last stream finishes/ends.
+    val last = streams.last()
+    if (last.canInvokeMember("once")) {
+      addOnce(last, StreamEventName.END, ProxyExecutable {
+        cleanupAll()
+        promise.resolve(Unit)
+      })
+      addOnce(last, StreamEventName.FINISH, ProxyExecutable {
+        cleanupAll()
+        promise.resolve(Unit)
+      })
+    }
+
+    // Handle already-completed/errored cases.
+    valueOrNull(last, "errored")?.let { err ->
+      if (!err.isNull) {
+        promise.reject(err)
+        return promise
+      }
+    }
+    val lastEnded = valueBooleanOrNull(last, "readableEnded") == true ||
+      valueBooleanOrNull(last, "writableFinished") == true
+    if (lastEnded) {
+      promise.resolve(Unit)
+      return promise
+    }
+
+    return promise
+  }
 
   override fun getMemberKeys(): Array<String> = ALL_PROMISES_PROPS
 
   override fun getMember(key: String?): Any? = when (key) {
     PIPELINE_FN -> ProxyExecutable { args ->
+
       val streams = args.toList()
       val promise = JsPromise<Unit>()
       if (streams.isEmpty()) return@ProxyExecutable promise.also { it.resolve(Unit) }
@@ -134,6 +287,15 @@ internal class NodeStreamPromises : ReadOnlyProxyObject, StreamPromisesAPI {
       on.execute("finish", doneCb)
       on.execute("error", errCb)
       promise
+      @Suppress("SpreadOperator")
+      pipeline(*args)
+    }
+    FINISHED_FN -> ProxyExecutable { args ->
+      val stream = args.getOrNull(0)
+        ?: return@ProxyExecutable elide.runtime.intrinsics.js.JsPromise.rejected<Unit>(
+          IllegalArgumentException("stream is required"),
+        )
+      finished(stream)
     }
     else -> null
   }