Compilation error on macOS #431
Description
Hello, I am currently running into the same problem as #389 on an iMac (Catalina 10.15.7). I am aware that #404 has already fixed this issue, but the latest copy of vterm-20201004 from elpa gives the same error.
-- System libvterm not found: libvterm will be downloaded and compiled as part of the build process
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/jslee/.emacs.d/elpa/develop/vterm-20201004.2057/build
[ 8%] Performing update step for 'libvterm'
[ 16%] No patch step for 'libvterm'
[ 25%] No configure step for 'libvterm'
[ 33%] Performing build step for 'libvterm'
CC bin/vterm-ctrl.c
bin/vterm-ctrl.c:117:10: error: implicit declaration of function 'strdup' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
return strdup(csi);
^
bin/vterm-ctrl.c:117:10: note: did you mean 'strcmp'?
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/string.h:77:6: note: 'strcmp' declared here
int strcmp(const char *__s1, const char *__s2);
^
bin/vterm-ctrl.c:117:10: warning: incompatible integer to pointer conversion returning 'int' from a function with result type 'char *' [-Wint-conversion]
return strdup(csi);
^~~~~~~~~~~
bin/vterm-ctrl.c:142:10: error: implicit declaration of function 'strdup' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
return strdup(dcs);
^
bin/vterm-ctrl.c:142:10: warning: incompatible integer to pointer conversion returning 'int' from a function with result type 'char *' [-Wint-conversion]
return strdup(dcs);
^~~~~~~~~~~
bin/vterm-ctrl.c:129:10: warning: result of comparison of constant 156 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare]
if(c == 0x9c) // ST
~ ^ ~~~~
3 warnings and 2 errors generated.
make[3]: *** [bin/vterm-ctrl] Error 1
make[2]: *** [libvterm-prefix/src/libvterm-stamp/libvterm-build] Error 2
make[1]: *** [CMakeFiles/libvterm.dir/all] Error 2
make: *** [all] Error 2
/Users/jslee/.emacs.d/elpa/develop/vterm-20201004.2057
Upon inspecting the above log message, I disovered that libvterm is checked out to 65dbda3, while the relevant fix is on 54c03b2, as discussed in #389. Is there any way I can force the commit to the latest one?
Thanks in advance!