-
Notifications
You must be signed in to change notification settings - Fork 33
Description
Describe the bug
I think react and react-dom should not be dependencies of this Node utilities.
To Reproduce
- Install typescript-coverage-report install another repository, not using react.
- Run
yarn why react
react
appears to be imported
=> Found "typescript-coverage-report#react@16.14.0"
info This module exists because "typescript-coverage-report" depends on it.
info Disk size without dependencies: "332KB"
info Disk size with unique dependencies: "520KB"
info Disk size with transitive dependencies: "600KB"
info Number of shared dependencies: 5
Expected behaviour
typescript-coverage-report
should not depend on react
, or react-dom
or semantic-ui-react
Environment
- Tool version: 0.7.0
- OS: Mac OSX
- Node version: 18.14.2
- Browser (if applicable): no
Additional context
Those dependencies should be devDependencies
in my opinion.
The required package should go in peerDependencies
example of react package.json: https://github.com/facebook/react/blob/main/package.json