use RuntimeError for when the box does not exists

Author: boblat

src/algopy_testing/models/box.py

@@ -45,15 +45,15 @@ def __bool__(self) -> bool:
     def key(self) -> algopy.Bytes:
         """Provides access to the raw storage key"""
         if not self._key:
-            raise ValueError("Box key is empty")
+            raise RuntimeError("Box key is empty")
         return self._key
 
     @property
     def value(self) -> _TValue:
         """Retrieve the contents of the box. Fails if the box has not been created."""
         context = get_test_context()
         if not context.does_box_exist(self.key):
-            raise ValueError("Box has not been created")
+            raise RuntimeError("Box has not been created")
         return _cast_to_value_type(self._type, context.get_box(self.key))
 
     @value.setter
@@ -100,7 +100,7 @@ def length(self) -> algopy.UInt64:
 
         context = get_test_context()
         if not context.does_box_exist(self.key):
-            raise ValueError("Box has not been created")
+            raise RuntimeError("Box has not been created")
         return algopy.UInt64(len(context.get_box(self.key)))
 
 
@@ -129,7 +129,7 @@ def __bool__(self) -> bool:
     def key(self) -> algopy.Bytes:
         """Provides access to the raw storage key"""
         if not self._key:
-            raise ValueError("Box key is empty")
+            raise RuntimeError("Box key is empty")
 
         return self._key
 
@@ -178,7 +178,7 @@ def extract(
         start_int = int(start_index)
         length_int = int(length)
         if not box_exists:
-            raise ValueError("Box does not exist")
+            raise RuntimeError("Box has not been created")
         if (start_int + length_int) > len(box_content):
             raise ValueError("Index out of bounds")
         result = box_content[start_int : start_int + length_int]
@@ -198,7 +198,7 @@ def resize(self, new_size: algopy.UInt64 | int) -> None:
             raise ValueError(f"Box size cannot exceed {MAX_BOX_SIZE}")
         box_content, box_exists = self._maybe()
         if not box_exists:
-            raise ValueError("Box has not been created")
+            raise RuntimeError("Box has not been created")
         if new_size_int > len(box_content):
             updated_content = box_content + b"\x00" * (new_size_int - len(box_content))
         else:
@@ -216,7 +216,7 @@ def replace(self, start_index: algopy.UInt64 | int, value: algopy.Bytes | bytes)
         context = get_test_context()
         box_content, box_exists = self._maybe()
         if not box_exists:
-            raise ValueError("Box has not been created")
+            raise RuntimeError("Box has not been created")
         start = int(start_index)
         length = len(value)
         if (start + length) > len(box_content):
@@ -252,7 +252,7 @@ def splice(
         insert_content = value.value if isinstance(value, algopy.Bytes) else value
 
         if not box_exists:
-            raise ValueError("Box has not been created")
+            raise RuntimeError("Box has not been created")
 
         if start > len(box_content):
             raise ValueError("Start index exceeds box size")
@@ -329,7 +329,7 @@ def length(self) -> algopy.UInt64:
 
         box_content, box_exists = self._maybe()
         if not box_exists:
-            raise ValueError("Box has not been created")
+            raise RuntimeError("Box has not been created")
         return algopy.UInt64(len(box_content))
 
 
@@ -371,7 +371,7 @@ def __init__(
     def key_prefix(self) -> algopy.Bytes:
         """Provides access to the raw storage key-prefix"""
         if not self._key_prefix:
-            raise ValueError("Box key prefix is empty")
+            raise RuntimeError("Box key prefix is empty")
         return self._key_prefix
 
     def __getitem__(self, key: _TKey) -> _TValue:
@@ -380,7 +380,7 @@ def __getitem__(self, key: _TKey) -> _TValue:
         """
         box_content, box_exists = self.maybe(key)
         if not box_exists:
-            raise ValueError("Box has not been created")
+            raise RuntimeError("Box has not been created")
         return box_content
 
     def __setitem__(self, key: _TKey, value: _TValue) -> None:
@@ -442,7 +442,7 @@ def length(self, key: _TKey) -> algopy.UInt64:
         key_bytes = self._full_key(key)
         box_exists = context.does_box_exist(key_bytes)
         if not box_exists:
-            raise ValueError("Box has not been created")
+            raise RuntimeError("Box has not been created")
         box_content_bytes = context.get_box(key_bytes)
         return algopy.UInt64(len(box_content_bytes))
 

src/algopy_testing/op.py

@@ -1063,7 +1063,7 @@ def extract(
         length = int(c)
         box_content = context.get_box(name_bytes)
         if not box_content:
-            raise ValueError("Box does not exist")
+            raise RuntimeError("Box does not exist")
         result = box_content[start : start + length]
         return algopy.Bytes(result)
 
@@ -1111,7 +1111,7 @@ def replace(
         new_content = c.value if isinstance(c, algopy.Bytes) else c
         box_content = context.get_box(name_bytes)
         if not box_content:
-            raise ValueError("Box does not exist")
+            raise RuntimeError("Box does not exist")
         if start + len(new_content) > len(box_content):
             raise ValueError("Replacement content exceeds box size")
         updated_content = (
@@ -1130,7 +1130,7 @@ def resize(a: algopy.Bytes | bytes, b: algopy.UInt64 | int, /) -> None:
             raise ValueError("Invalid box name or size")
         box_content = context.get_box(name_bytes)
         if not box_content:
-            raise ValueError("Box does not exist")
+            raise RuntimeError("Box does not exist")
         if new_size > len(box_content):
             updated_content = box_content + b"\x00" * (new_size - len(box_content))
         else:
@@ -1155,7 +1155,7 @@ def splice(
         box_content = context.get_box(name_bytes)
 
         if not box_content:
-            raise ValueError("Box does not exist")
+            raise RuntimeError("Box does not exist")
 
         if start > len(box_content):
             raise ValueError("Start index exceeds box size")

tests/models/test_box.py

@@ -59,10 +59,10 @@ def test_init_with_key(
     )
     assert box.key == key_bytes
 
-    with pytest.raises(ValueError, match=BOX_NOT_CREATED_ERROR):
+    with pytest.raises(RuntimeError, match=BOX_NOT_CREATED_ERROR):
         _ = box.value
 
-    with pytest.raises(ValueError, match=BOX_NOT_CREATED_ERROR):
+    with pytest.raises(RuntimeError, match=BOX_NOT_CREATED_ERROR):
         _ = box.length
 
 
@@ -117,7 +117,7 @@ def test_value_deleter(
     del box.value
     assert not box
 
-    with pytest.raises(ValueError, match=BOX_NOT_CREATED_ERROR):
+    with pytest.raises(RuntimeError, match=BOX_NOT_CREATED_ERROR):
         _ = box.value
 
     op_box_content, op_box_exists = algopy.op.Box.get(key)

tests/models/test_box_map.py

@@ -61,10 +61,10 @@ def test_init_with_key_prefix(
     )
     assert box.key_prefix == key_prefix_bytes
 
-    with pytest.raises(ValueError, match=BOX_NOT_CREATED_ERROR):
+    with pytest.raises(RuntimeError, match=BOX_NOT_CREATED_ERROR):
         _ = box[key_type()]
 
-    with pytest.raises(ValueError, match=BOX_NOT_CREATED_ERROR):
+    with pytest.raises(RuntimeError, match=BOX_NOT_CREATED_ERROR):
         _ = box.length(key_type())
 
 
@@ -134,7 +134,7 @@ def test_value_deleter(
 
     del box[key]
 
-    with pytest.raises(ValueError, match=BOX_NOT_CREATED_ERROR):
+    with pytest.raises(RuntimeError, match=BOX_NOT_CREATED_ERROR):
         _ = box[key]
 
     full_key = box._full_key(key)

tests/models/test_box_ref.py

@@ -54,7 +54,7 @@ def test_init_with_key(
     )
     assert box.key == key_bytes
 
-    with pytest.raises(ValueError, match=BOX_NOT_CREATED_ERROR):
+    with pytest.raises(RuntimeError, match=BOX_NOT_CREATED_ERROR):
         _ = box.length
 
 
@@ -101,13 +101,13 @@ def test_delete(
     assert box_existed
     assert not box
 
-    with pytest.raises(ValueError, match=BOX_NOT_CREATED_ERROR):
+    with pytest.raises(RuntimeError, match=BOX_NOT_CREATED_ERROR):
         _ = box.length
 
-    with pytest.raises(ValueError, match=BOX_NOT_CREATED_ERROR):
+    with pytest.raises(RuntimeError, match=BOX_NOT_CREATED_ERROR):
         box.resize(10)
 
-    with pytest.raises(ValueError, match=BOX_NOT_CREATED_ERROR):
+    with pytest.raises(RuntimeError, match=BOX_NOT_CREATED_ERROR):
         box.replace(0, b"\x11")
 
     assert not box.delete()
@@ -191,7 +191,7 @@ def test_replace_when_box_does_not_exists(
 ) -> None:
     box = BoxRef(key=TEST_BOX_KEY)
 
-    with pytest.raises(ValueError, match=BOX_NOT_CREATED_ERROR):
+    with pytest.raises(RuntimeError, match=BOX_NOT_CREATED_ERROR):
         box.replace(0, b"\x11")
 
 
@@ -377,7 +377,7 @@ def test_splice_when_box_does_not_exist(
 ) -> None:
     box = BoxRef(key=TEST_BOX_KEY)
 
-    with pytest.raises(ValueError, match=BOX_NOT_CREATED_ERROR):
+    with pytest.raises(RuntimeError, match=BOX_NOT_CREATED_ERROR):
         box.splice(0, 1, b"\x11")