Skip to content

MetricNode#toFatString 时间转换影响性能 #3463

New issue
New issue
Open
#3466
Open
MetricNode#toFatString 时间转换影响性能#3463
#3466
@brucelwl

Description

@brucelwl
brucelwl
opened on Oct 27, 2024

Sentinel/sentinel-core/src/main/java/com/alibaba/csp/sentinel/node/metric/MetricNode.java

Lines 213 to 230 in 195150b

public String toFatString() {
DateFormat df = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
StringBuilder sb = new StringBuilder(32);
sb.delete(0, sb.length());
sb.append(getTimestamp()).append("|");
sb.append(df.format(new Date(getTimestamp()))).append("|");
String legalName = getResource().replaceAll("\\|", "_");
sb.append(legalName).append("|");
sb.append(getPassQps()).append("|");
sb.append(getBlockQps()).append("|");
sb.append(getSuccessQps()).append("|");
sb.append(getExceptionQps()).append("|");
sb.append(getRt()).append("|");
sb.append(getOccupiedPassQps()).append("|");
sb.append(concurrency).append("|");
sb.append(classification);
sb.append('\n');
return sb.toString();

214行, 每次都创建新的SimpleDateFormat影响性能, 改成java8的时间吧

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions