Convert usernames to mentions not working in Slack

[PMunch]

I have turned on the "Convert names to mentions?" option in the configuration of this app, and I've set the channel it is posting in to only notify myself when I get mentioned. Unfortunately it doesn't appear to notify me when a message mentions me. It uses the same name in the message as my name on Slack, so I'm not exactly sure what's going wrong here.

Happy to help out if you need more information.

[PMunch]

Looked into this a bit and apparently Slack mentions through webhooks have to be done via Slack IDs. Would it be possible for this plugin to support a custom user field with Slack ID to convert names into proper mentions?

[PMunch]

Apparently it's also possible to use the part in-front of the e-mail of the user. Probably some limitations on who can be mentioned this way (I would assume only those who have a company e-mail) but for our usecase this is perfect. I made this quick and dirty change to app/models/messenger.rb and it works a treat:

diff --git a/app/models/messenger.rb b/app/models/messenger.rb
index bcdf274..5e1f76e 100644
--- a/app/models/messenger.rb
+++ b/app/models/messenger.rb
@@ -215,7 +215,7 @@ class Messenger
       when 'category'
         value = object_field_value IssueCategory, detail.value
       when 'assigned_to', 'author'
-        value = object_field_value Principal, detail.value
+        value = object_field_mention Principal, detail.value
       when 'fixed_version'
         value = object_field_value Version, detail.value
       when 'attachment'
@@ -267,6 +267,11 @@ class Messenger
       obj.nil? ? id.to_s : obj.to_s
     end
 
+    def object_field_mention(klass, id)
+      obj = klass.find_by id: id
+      obj.nil? ? id.to_s : "@#{obj.mail.sub!("@ourcompany.com", "").to_s}"
+    end
+
     def extract_usernames(text)
       return [] if text.blank?

Obviously not a general fix because of the hard-coded e-mail, but just removing anything after a @ should work as well. I'm just not versed enough in Ruby to easily do that.

[PMunch]

Created a draft PR for this functionality: #117