Skip to content

Commit 0b0a3c6

Browse files
authored
Fix ci build dependencies (#91)
* Test: Add comment to verify CI checks pass Small change to test that existing CI workflow works correctly without any linting modifications. * Fix CI build by resolving package dependencies - Add -resolvePackageDependencies step before build - Fixes missing AWSConnectParticipant-Target.o error * Fix: Use stable Xcode 15.4 instead of beta The latest Xcode (26 beta) was causing build issues with AWSConnectParticipant-Target.o. Using stable 15.4 version. * Remove unnecessary dependency resolution step The Xcode version fix should be sufficient, no need for manual dependency resolution. * Use latest stable Xcode version 16.4.0 Updated from 15.4 to 16.4.0 which is the latest stable (GM) version available on GitHub Actions runners. * Add optional latest Xcode compatibility test - Added test-latest-xcode job that tests with latest Xcode version - Uses continue-on-error: true so it won't block the main build - Helps identify compatibility issues with newer Xcode versions * Make latest Xcode test non-blocking for PRs - Only runs on main branch pushes, not on PRs - This way it won't show as a failed check that blocks PR merging - Still provides feedback on Xcode compatibility after merge * Create separate Xcode compatibility workflow - Moved latest Xcode test to separate workflow file - This creates a separate check that can be ignored for PR merging - Main build workflow remains required, compatibility test is optional * Update job names to indicate optional status - Workflow name: 'Xcode Compatibility Test (Optional)' - Job name: 'test-latest-xcode-optional' - Step name includes '(Optional)' - Makes it clear this check doesn't need to pass for merging * Make it crystal clear PR can merge even if check fails - Workflow: 'Xcode Compatibility (Can Fail - PR Can Still Merge)' - Job: 'test-latest-xcode-can-fail' - Step: 'Failure OK - PR Can Still Merge' - Removes any confusion about merge requirements * Fix simulator compatibility with Xcode 16.1.0 - Use Xcode 16.1.0 (stable GM version from the table) - Use iOS 18.0 simulator which should be available in Xcode 16.1 - This should resolve the device matching error * Use Xcode 16.4.0 and remove optional compatibility check - Back to Xcode 16.4.0 (latest stable) - Removed separate xcode-compatibility.yml workflow - Simplified to single required build check * Use iPhone 16 with iOS 18.4 simulator Based on available simulators list, iPhone 16 with iOS 18.4 is available and closest to the original iPhone 15 setup. * Add print() statement linting check - Added minimal linting step at end of workflow - Checks for print() statements in Swift files - Fails build if any print() statements are found
1 parent 3c2e7b1 commit 0b0a3c6

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

.github/workflows/Build.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- name: Set up Xcode
2020
uses: maxim-lobanov/setup-xcode@v1
2121
with:
22-
xcode-version: 'latest'
22+
xcode-version: '16.4.0'
2323

2424
- name: Set up Ruby
2525
uses: ruby/setup-ruby@v1
@@ -47,8 +47,8 @@ jobs:
4747
echo "Available schemes:"
4848
xcodebuild -list -project AmazonConnectChatIOS.xcodeproj
4949
50-
# Use iPhone 15 with iOS 17.5
51-
DESTINATION="platform=iOS Simulator,OS=17.5,name=iPhone 15"
50+
# Use iPhone 16 with iOS 18.4 (available in Xcode 16.4)
51+
DESTINATION="platform=iOS Simulator,OS=18.4,name=iPhone 16"
5252
5353
# Run tests with AmazonConnectChatIOSTests scheme
5454
echo "Running tests with AmazonConnectChatIOSTests scheme..."
@@ -72,3 +72,12 @@ jobs:
7272
echo "✅ All tests passed"
7373
fi
7474
echo "::endgroup::"
75+
76+
- name: Check for print() statements
77+
run: |
78+
if grep -r "print(" --include="*.swift" . --exclude-dir=".git"; then
79+
echo "❌ ERROR: Found print() statements in Swift files"
80+
exit 1
81+
else
82+
echo "✅ No print() statements found"
83+
fi

0 commit comments

Comments
 (0)