Skip to content

Commit 95f63fb

Browse files
Fix in convert_params naming due to Pydantic v2 upgrade
1 parent b6875f0 commit 95f63fb

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/fmcore/data/writer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class Params(DataFrameWriter.Params):
2525

2626
@model_validator(mode="before")
2727
@classmethod
28-
def convert_params(cls, params: Dict):
28+
def _metrics_writer_params_convert_params(cls, params: Dict):
2929
metric_list: List[Metric] = [
3030
Metric.of(
3131
metric_dict.get("metric_name"),
@@ -42,7 +42,7 @@ def convert_params(cls, params: Dict):
4242

4343
@model_validator(mode="before")
4444
@classmethod
45-
def convert_params(cls, params: Dict):
45+
def _metrics_writer_convert_params(cls, params: Dict):
4646
params["params"] = cls._convert_params(cls.Params, params)
4747
return params
4848

src/fmcore/framework/_algorithm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ def create_hyperparams(cls, hyperparams: Optional[Dict] = None) -> Hyperparamete
230230

231231
@model_validator(mode="before")
232232
@classmethod
233-
def convert_params(cls, params: Dict) -> Dict:
233+
def _algorithm_convert_params(cls, params: Dict) -> Dict:
234234
## Convert and validate parameters for the algorithm
235235
# print(f'params for {cls.class_name}=\n{params}')
236236
cls.set_default_param_values(params)

src/fmcore/framework/_metric.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,8 @@ def _pre_registration_hook(cls):
122122

123123
@model_validator(mode="before")
124124
@classmethod
125-
def convert_params(cls, params: Dict):
126-
print(f'Metric params: {params}')
125+
def _metric_convert_params(cls, params: Dict):
126+
# print(f'Metric params: {params}')
127127
params["params"] = super(Metric, cls)._convert_params(cls.Params, params.get("params"))
128128
params["name"] = cls.class_name
129129
if "value" in params:

src/fmcore/framework/_visualize.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ class Params(Visualization.Params):
158158

159159
@model_validator(mode="before")
160160
@classmethod
161-
def convert_params(cls, params: Dict):
161+
def _visualize_convert_params(cls, params: Dict):
162162
params["params"] = super(Visualization, cls)._convert_params(cls.Params, params.get("params"))
163163
params["name"] = cls.class_name
164164
return params

0 commit comments

Comments
 (0)