Skip to content

Commit 6a50593

Browse files
committed
use this in getUnsupportedTargets
1 parent 722edeb commit 6a50593

File tree

6 files changed

+9
-12
lines changed

6 files changed

+9
-12
lines changed

src/providers/caniuse-provider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@ function isSupportedByCanIUse(
7171
* Return an array of all unsupported targets
7272
*/
7373
export function getUnsupportedTargets(
74-
node: AstMetadataApiWithTargetsResolver,
74+
this: AstMetadataApiWithTargetsResolver,
7575
targets: Target[]
7676
): string[] {
7777
return targets
78-
.filter((target) => !isSupportedByCanIUse(node, target))
78+
.filter((target) => !isSupportedByCanIUse(this, target))
7979
.map(formatTargetNames);
8080
}
8181

src/providers/mdn-provider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,11 @@ export function isSupportedByMDN(
112112
* Return an array of all unsupported targets
113113
*/
114114
export function getUnsupportedTargets(
115-
node: AstMetadataApiWithTargetsResolver,
115+
this: AstMetadataApiWithTargetsResolver,
116116
targets: Target[]
117117
): string[] {
118118
return targets
119-
.filter((target) => !isSupportedByMDN(node, target))
119+
.filter((target) => !isSupportedByMDN(this, target))
120120
.map(formatTargetNames);
121121
}
122122

src/rules/compat.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ const getRulesForTargets = memoize(
130130
nodes
131131
.filter((node) => (lintAllEsApis ? true : node.kind !== "es"))
132132
.forEach((node) => {
133-
if (!node.getUnsupportedTargets(node, targets).length) return;
133+
if (!node.getUnsupportedTargets(targets).length) return;
134134
result[node.astNodeType].push(node);
135135
});
136136

@@ -205,7 +205,7 @@ export default {
205205
message: [
206206
generateErrorName(node),
207207
"is not supported in",
208-
node.getUnsupportedTargets(node, browserslistTargets).join(", "),
208+
node.getUnsupportedTargets(browserslistTargets).join(", "),
209209
].join(" "),
210210
});
211211
};

src/types.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,7 @@ export interface AstMetadataApiWithTargetsResolver extends AstMetadataApi {
5555
id: string;
5656
caniuseId?: string;
5757
kind?: APIKind;
58-
getUnsupportedTargets: (
59-
node: AstMetadataApiWithTargetsResolver,
60-
targets: Target[]
61-
) => Array<string>;
58+
getUnsupportedTargets: (targets: Target[]) => Array<string>;
6259
}
6360

6461
export interface Context extends Rule.RuleContext {

test/caniuse-provider.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe("CanIUseProvider", () => {
1414
expectRangeResultJSON.browsers
1515
);
1616
const targets = parseBrowsersListVersion(config);
17-
const result = getUnsupportedTargets(node, targets);
17+
const result = getUnsupportedTargets.call(node, targets);
1818
expect(result).toMatchSnapshot();
1919
});
2020
});

test/mdn-provider.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ describe("MdnProvider", () => {
1212
} as AstMetadataApiWithTargetsResolver;
1313
const config = determineTargetsFromConfig(".", ["safari tp"]);
1414
const targets = parseBrowsersListVersion(config);
15-
const result = getUnsupportedTargets(node, targets);
15+
const result = getUnsupportedTargets.call(node, targets);
1616
expect(result).toEqual([]);
1717
});
1818
});

0 commit comments

Comments
 (0)